Skip to content

feat(httpupdate): Add optional httpclient to update #10092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(httpupdate): Add optional httpclient to update #10092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libraries/HTTPUpdate/src/HTTPUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ HTTPUpdateResult HTTPUpdate::update(NetworkClient &client, const String &url, co
}
return handleUpdate(http, currentVersion, false, requestCB);
}
HTTPUpdateResult HTTPUpdate::update(NetworkClient &client,HTTPClient &httpclient, const String &url, const String &currentVersion, HTTPUpdateRequestCB requestCB){
if (!httpclient.begin(client, url)) {
return HTTP_UPDATE_FAILED;
}
return handleUpdate(httpclient, currentVersion, false, requestCB);
}

HTTPUpdateResult HTTPUpdate::updateSpiffs(HTTPClient &httpClient, const String &currentVersion, HTTPUpdateRequestCB requestCB) {
return handleUpdate(httpClient, currentVersion, true, requestCB);
Expand Down
4 changes: 4 additions & 0 deletions libraries/HTTPUpdate/src/HTTPUpdate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ class HTTPUpdate {
}

t_httpUpdate_return update(NetworkClient &client, const String &url, const String &currentVersion = "", HTTPUpdateRequestCB requestCB = NULL);

t_httpUpdate_return update(
NetworkClient &client,HTTPClient &httpclient, const String &url, const String &currentVersion = "", HTTPUpdateRequestCB requestCB = NULL
);

t_httpUpdate_return update(
NetworkClient &client, const String &host, uint16_t port, const String &uri = "/", const String &currentVersion = "", HTTPUpdateRequestCB requestCB = NULL
Expand Down