Skip to content

Fix use after free in SD library #10122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix use after free in SD library #10122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a71724
fix(sd): Fix use after free
Ariakenom Aug 6, 2024
60e9415
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/SD/src/sd_diskio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,8 +671,10 @@ uint8_t sdcard_uninit(uint8_t pdrv) {
if (pdrv >= FF_VOLUMES || card == NULL) {
return 1;
}
AcquireSPI lock(card);
sdTransaction(pdrv, GO_IDLE_STATE, 0, NULL);
{
AcquireSPI lock(card);
sdTransaction(pdrv, GO_IDLE_STATE, 0, NULL);
} // lock is destructed here
ff_diskio_register(pdrv, NULL);
s_cards[pdrv] = NULL;
esp_err_t err = ESP_OK;
Expand Down