Skip to content

Conversation

victorfleischauer
Copy link


Description of Change

Changed the parameter MBEDTLS_AES_ENCRYPT to MBEDTLS_AES_DECRYPT for the function mbedtls_aes_crypt_ecb in the method _decryptBuffer(). This change can affect anyone who currently uses the decryption functionality of the Update.h library.

I hope this helps, or that my understanding is corrected, thanks!

Tests scenarios

As described in my Issue:

  • Board: ESP32-S3-DevKitC-1 v1.0
  • Version: 3.0.4
  • IDE: PlatformIO
  • Operating System: Windows 11

Description

A slightly modified version of the example sketch "OTAWebUpdater" to include

const uint8_t key[32] = {/* PUT YOUR KEY HERE */};
Update.setupCrypt(key, 0, 0, U_AES_DECRYPT_ON);

Related links

Issue opened, will be closed by this PR

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Warnings
⚠️

The source branch "fix/fixUpdateDecrypt" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello victorfleischauer, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b200c42

@victorfleischauer
Copy link
Author

victorfleischauer commented Aug 19, 2024

Bad branch name, corrected PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants