Skip to content

Conversation

glitched-w0rld
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Warnings
⚠️ The Pull Request description is empty. Please provide a detailed description.

👋 Hello DemoYeti, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2c1b3db

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from lucasssvaz August 26, 2024 06:39
@VojtechBartoska VojtechBartoska added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. Status: Review needed Issue or PR is awaiting review labels Aug 26, 2024
Copy link
Member

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct.

The files going to the right (tests_results.yml and tests_wokwi.yml) run on workflow_run, meaning that they will only be run after the previous one finishes.

The files listed below, on the other hand, run on workflow_call. Meaning they will be called by tests.yml and run as it is a job inside this file/workflow.

@lucasssvaz lucasssvaz added Resolution: Awaiting response and removed Status: Review needed Issue or PR is awaiting review labels Aug 29, 2024
Copy link
Contributor

Test Results

 56 files   -  83   56 suites   - 83   4m 53s ⏱️ - 1h 38m 16s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 2c1b3db. ± Comparison against base commit cd3d0bf.

This pull request removes 9 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

@me-no-dev
Copy link
Member

Closing per comment from @lucasssvaz

@me-no-dev me-no-dev closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants