Skip to content

ESPmDNS: Add method for querying discovered service name #10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2025
Merged

ESPmDNS: Add method for querying discovered service name #10819

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c41c8f0
Add method for querying service name
stefan-sherwood Jan 6, 2025
e6670a4
Added implementation for getting service name
stefan-sherwood Jan 6, 2025
33988ca
Update mDNS-SD_Extended example to include service name
stefan-sherwood Jan 6, 2025
da15c76
Merge branch 'master' into mdns_get_instance_name
stefan-sherwood Jan 7, 2025
25658e9
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libraries/ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ void browseService(const char *service, const char *proto) {
Serial.print(" ");
Serial.print(i + 1);
Serial.print(": ");
Serial.print(MDNS.instanceName(i));
Serial.print(" - ");
Serial.print(MDNS.hostname(i));
Serial.print(" (");
Serial.print(MDNS.address(i));
Expand Down
10 changes: 10 additions & 0 deletions libraries/ESPmDNS/src/ESPmDNS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,16 @@ String MDNSResponder::hostname(int idx) {
return String(result->hostname);
}

String MDNSResponder::instanceName(int idx) {
mdns_result_t *result = _getResult(idx);
if (!result) {
log_e("Result %d not found", idx);
return String();
}
return String(result->instance_name);
}


IPAddress MDNSResponder::address(int idx) {
mdns_result_t *result = _getResult(idx);
if (!result) {
Expand Down
1 change: 1 addition & 0 deletions libraries/ESPmDNS/src/ESPmDNS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ class MDNSResponder {
}

String hostname(int idx);
String instanceName(int idx);
IPAddress address(int idx);
IPAddress addressV6(int idx);
uint16_t port(int idx);
Expand Down
Loading