Skip to content

feat(gpio): allows mixing digital and analog read/write operations #11016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 9, 2025
Merged

feat(gpio): allows mixing digital and analog read/write operations #11016

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
130dbd6
feat(gpio): allows mixing digital and analog read/write operations
SuGlider Feb 26, 2025
8bdee60
fix(gpio): simple mistake in calling __pinMode() fnuction
SuGlider Feb 26, 2025
993ddd9
fix(gpio): simple mistake in calling __pinMode() fnuction
SuGlider Feb 26, 2025
54895fc
Merge branch 'master' into mixing_digital_analog_read_write
SuGlider Feb 26, 2025
b34be47
feat(gpio): update the log message to tell the solution for the error.
SuGlider Feb 27, 2025
97d78bc
feat(gpio): warn user about digitalRead() used with non GPIO pin
SuGlider Feb 27, 2025
8cd18ac
fix(gpio): wrong peripheral manager test case
SuGlider Feb 28, 2025
7e008c8
Merge branch 'master' into mixing_digital_analog_read_write
SuGlider Mar 5, 2025
d3a02f0
Merge branch 'master' into mixing_digital_analog_read_write
SuGlider Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cores/esp32/esp32-hal-gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ extern void ARDUINO_ISR_ATTR __digitalWrite(uint8_t pin, uint8_t val) {
if (perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) != NULL) {
gpio_set_level((gpio_num_t)pin, val);
} else {
log_e("IO %i is not set as GPIO.", pin);
log_e("IO %i is not set as GPIO. Execute digitalMode(pin, OUTPUT) first.", pin);
}
}

Expand All @@ -182,14 +182,12 @@ extern int ARDUINO_ISR_ATTR __digitalRead(uint8_t pin) {
if (pin == RGB_BUILTIN) {
return RGB_BUILTIN_storage;
}
#endif

#endif // RGB_BUILTIN
// This work when the pin is set as GPIO and in INPUT mode. For all other pin functions, it may return inconsistent response
if (perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) != NULL) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check if getPinBus is equal to NULL, else you are sending warning when the pin is actually set as GPIO

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

return gpio_get_level((gpio_num_t)pin);
} else {
log_e("IO %i is not set as GPIO.", pin);
return 0;
log_w("IO %i is not set as GPIO. digitalRead() may return an inconsistent value.");
}
return gpio_get_level((gpio_num_t)pin);
}

static void ARDUINO_ISR_ATTR __onPinInterrupt(void *arg) {
Expand Down
Loading