Skip to content

fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2025
Merged

fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() #11070

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f3490a
fix(matter): itshall set digital mode before digitalWrite
SuGlider Mar 10, 2025
94b43d8
fix(matter): example must set pin in digital mode before writting
SuGlider Mar 10, 2025
05402c4
fix(matter): example shall set digital mode before writing
SuGlider Mar 10, 2025
1ec6a9d
fix(matter): digitalMode necessary before digitalWrite(LOW)
SuGlider Mar 10, 2025
ed2d571
fix(matter): example must set digital mode after analogwrite
SuGlider Mar 10, 2025
dbe2cb0
Merge branch 'master' into fix/matter_examples_digitalWrite
SuGlider Mar 10, 2025
e2bb733
fix(matter): wrong copy paste
SuGlider Mar 10, 2025
9401cf9
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/Matter/examples/MatterColorLight/MatterColorLight.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ bool setLightState(bool state, espHsvColor_t colorHSV) {
analogWrite(ledPin, colorHSV.v);
#endif
} else {
#ifndef RGB_BUILTIN
// after analogWrite(), it is necessary to set the GPIO to digital mode first
pinMode(ledPin, OUTPUT);
#endif
digitalWrite(ledPin, LOW);
}
// store last HSV Color and OnOff state for when the Light is restarted / power goes off
Expand Down
4 changes: 4 additions & 0 deletions libraries/Matter/examples/MatterDimmableLight/MatterDimmableLight.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ bool setLightState(bool state, uint8_t brightness) {
analogWrite(ledPin, brightness);
#endif
} else {
#ifndef RGB_BUILTIN
// after analogWrite(), it is necessary to set the GPIO to digital mode first
pinMode(ledPin, OUTPUT);
#endif
digitalWrite(ledPin, LOW);
}
// store last Brightness and OnOff state for when the Light is restarted / power goes off
Expand Down
4 changes: 4 additions & 0 deletions libraries/Matter/examples/MatterEnhancedColorLight/MatterEnhancedColorLight.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ bool setLightState(bool state, espHsvColor_t colorHSV, uint8_t brighteness, uint
analogWrite(ledPin, colorHSV.v);
#endif
} else {
#ifndef RGB_BUILTIN
// after analogWrite(), it is necessary to set the GPIO to digital mode first
pinMode(ledPin, OUTPUT);
#endif
digitalWrite(ledPin, LOW);
}
// store last HSV Color and OnOff state for when the Light is restarted / power goes off
Expand Down
6 changes: 5 additions & 1 deletion libraries/Matter/examples/MatterFan/MatterFan.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ void fanDCMotorDrive(bool fanState, uint8_t speedPercent) {
// drive the Fan DC motor
if (fanState == false) {
// turn off the Fan
digitalWrite(dcMotorPin, LOW);
#ifndef RGB_BUILTIN
// after analogWrite(), it is necessary to set the GPIO to digital mode first
pinMode(ledPin, OUTPUT);
#endif
digitalWrite(dcMotorPin, LOW);
} else {
// set the Fan speed
uint8_t fanDCMotorPWM = map(speedPercent, 0, 100, 0, 255);
Expand Down
4 changes: 4 additions & 0 deletions libraries/Matter/examples/MatterTemperatureLight/MatterTemperatureLight.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ bool setLightState(bool state, uint8_t brightness, uint16_t temperature_Mireds)
analogWrite(ledPin, brightness);
#endif
} else {
#ifndef RGB_BUILTIN
// after analogWrite(), it is necessary to set the GPIO to digital mode first
pinMode(ledPin, OUTPUT);
#endif
digitalWrite(ledPin, LOW);
}
// store last Brightness and OnOff state for when the Light is restarted / power goes off
Expand Down
Loading