Skip to content

Update HTTPUpdateServer.h to Fix SPIFFS Update error: Bad Size Given #11586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
+1 −2
Merged

Update HTTPUpdateServer.h to Fix SPIFFS Update error: Bad Size Given #11586

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3afef7
Update HTTPUpdateServer.h
kapyaar Jul 11, 2025
f1e4812
Merge branch 'master' into master
me-no-dev Sep 16, 2025
b977457
fix(HTTPUpdateServer): Remove SPIFFS.h include
me-no-dev Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libraries/HTTPUpdateServer/src/HTTPUpdateServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#ifndef __HTTP_UPDATE_SERVER_H
#define __HTTP_UPDATE_SERVER_H

#include <SPIFFS.h>
#include <StreamString.h>
#include <Update.h>
#include <WebServer.h>
Expand Down Expand Up @@ -123,7 +122,7 @@ class HTTPUpdateServer {
Serial.printf("Update: %s\n", upload.filename.c_str());
}
if (upload.name == "filesystem") {
if (!Update.begin(SPIFFS.totalBytes(), U_SPIFFS)) { //start with max available size
if (!Update.begin(UPDATE_SIZE_UNKNOWN, U_SPIFFS)) { //Instead of SPIFFS.totalBytes(). Fix https://github.com/espressif/arduino-esp32/issues/9967
if (_serial_output) {
Update.printError(Serial);
}
Expand Down
Loading