Skip to content

feat(board): add support for FoBE Quill ESP32-S3 Mesh #11693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

chihosin
Copy link

@chihosin chihosin commented Aug 4, 2025

This pull request introduces support for the FoBE Quill ESP32-S3 Mesh board by adding its configuration to the boards.txt file and defining its pin mappings in pins_arduino.h. These changes primarily implement compatibility for the FoBE Quill ESP32-S3 Mesh hardware and provide the necessary settings for its operation.

image

Product link: https://docs.fobestudio.com/product/f1102
Vendor: FoBE Studio

This commit introduces support for the FoBE Quill ESP32-S3 Mesh by adding necessary configuration files, including bootloader, pin definitions, and variant initialization code.

Signed-off-by: ChihoSin [email protected]
This commit improves the readability of the pin definitions by standardizing the indentation across the relevant sections.

Signed-off-by: ChihoSin [email protected]
@chihosin chihosin requested a review from P-R-O-C-H-Y as a code owner August 4, 2025 16:43
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(pins): Adjust indentation for pin definitions":
    • body's lines must not be longer than 100 characters
  • the commit message "variants: Add FoBE Quill ESP32-S3 Mesh support":
    • body's lines must not be longer than 100 characters
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello chihosin, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 49b4b57

@chihosin chihosin closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants