-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(pins_arduino): Fixes te mask for the Watchy Device pins #11738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes compilation errors in the Watchy device pins configuration by replacing deprecated GPIO_SEL_*
constants with BIT64()
macro calls. The issue was causing builds to fail when using the Watchy board with Arduino IDE examples.
- Replaces hardcoded
GPIO_SEL_*
constants with dynamicBIT64()
macro calculations - Removes version-specific
UP_BTN_MASK
definitions and consolidates mask definitions - Updates all button and interrupt pin masks to use the corrected format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@P-R-O-C-H-Y PTAL |
Description of Change
Based on user report, the Watchy
pins-arduino.h
causes compilation error.It shall follow https://github.com/sqfmi/Watchy/blob/master/src/config.h
Test Scenarios
Select Watchy board and try to compile a basic sketch
The board revision will default to "Watchy 2.0". Leave it that way.
Open Arduino IDE Examples -> Watchy -> WatchFaces -> Basic.ino
Error Message that shall be fixed with this PR:
Related links
Closes #11737