-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(board): add support for Silicognition ManT1S #11848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add board configuration to `boards.txt` - Add pin and Ethernet definitions to `variants/mant1s`
👋 Hello xorbit, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
4a0dad0
to
67cd439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I received a comment about the placement in |
@xorbit All good, I have removed the comment, as the board above is from Silicognition. Missed that first time. Its ready to be merged ;) |
Description of Change
Add new board Silicognition ManT1S: https://www.crowdsupply.com/silicognition/mant1s
boards.txt
.variants/mant1s
.Test Scenarios
This requires LAN867x support so depends on #11843, which is not in any release. So it was tested on
master
on a prototype ManT1S rev 4. Works as expected with unmodified ETH_LAN8720 example, sincepins_arduino.h
definesETH_PHY_MDC
correctly for the ManT1S the config block on top of the example is ignored and uses the correct Ethernet definitions frompins_arduino.h
instead.Related links
Depends on #11843 and library built with the LAN867x supports this adds.