Skip to content

Conversation

xorbit
Copy link
Contributor

@xorbit xorbit commented Sep 16, 2025

Description of Change

Add new board Silicognition ManT1S: https://www.crowdsupply.com/silicognition/mant1s

  • Add board configuration to boards.txt.
  • Add pin definitions and T1S Ethernet config to variants/mant1s.

mant1s-angle-01

Test Scenarios

This requires LAN867x support so depends on #11843, which is not in any release. So it was tested on master on a prototype ManT1S rev 4. Works as expected with unmodified ETH_LAN8720 example, since pins_arduino.h defines ETH_PHY_MDC correctly for the ManT1S the config block on top of the example is ignored and uses the correct Ethernet definitions from pins_arduino.h instead.

Related links

Depends on #11843 and library built with the LAN867x supports this adds.

- Add board configuration to `boards.txt`
- Add pin and Ethernet definitions to `variants/mant1s`
@xorbit xorbit requested a review from P-R-O-C-H-Y as a code owner September 16, 2025 17:10
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Sep 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello xorbit, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 67cd439

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Sep 16, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Sep 16, 2025
@xorbit
Copy link
Contributor Author

xorbit commented Sep 16, 2025

I received a comment about the placement in boards.txt in my email but I can't see it here. This is a Silicognition board, so I put it right below the other Silicognition board, the wESP32.

@P-R-O-C-H-Y
Copy link
Member

@xorbit All good, I have removed the comment, as the board above is from Silicognition. Missed that first time. Its ready to be merged ;)

@me-no-dev me-no-dev merged commit e2254cc into espressif:master Sep 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants