-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(ota): Add legacy option for devices using MD5 authentication #11862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
feaffc8
to
dc4fa6c
Compare
Did you test this with ArduinoOTA example? Given that there are no changes to |
Yeah, it works fine. As described in the PR it will first try to use the new authentication and if it fails fallback to the old one. |
Description of Change
This pull request updates the
espota.py
tool to add support for authenticating with devices that use an older, insecure MD5-based challenge/response protocol, improving compatibility with legacy firmware. The main changes include introducing a new--md5-target
option, updating the authentication flow to handle both MD5 and SHA256 mechanisms, and adjusting the argument parsing and function signatures accordingly.It will first try with SHA authentication and if it fails it will try again with MD5 for backwards compatibility.
Authentication protocol updates:
--md5-target
(-m
) command-line flag to indicate that the target device uses MD5-based authentication, for compatibility with old firmware.serve
function and its call sites to accept an additionalmd5_target
argument, controlling which authentication protocol is used. [1] [2]serve
to:Test Scenarios
Tested with ESP32-C6
Related links
Closes #11855