Skip to content

Conversation

bekirr12
Copy link
Contributor

@bekirr12 bekirr12 commented Sep 26, 2025

This pull request addresses a missing board definition for the Twin AIoT module in the boards.txt file, resolving a critical upload error. This change is to solve the error we received in the twinaiot module that we added in the previous PR.

Problem Description
When attempting to upload a sketch to the Twin AIoT board, the build and upload process failed due to a missing line in the board's configuration file. The specific error message received was:

No such command '{upload.flags}'

This error was caused by the absence of the upload.flags and upload.extra_flags parameters in the Twin AIoT Module definition. The Arduino IDE's build system, which uses the platform.txt template, was unable to correctly format the esptool.py command-line arguments without these keys, leading to a failed upload.

Solution
This pull request adds the following lines to the Twin AIoT Module definition in the boards.txt file:

twinaiot.upload.flags=
twinaiot.upload.extra_flags=

This simple correction ensures that the build system can properly resolve the command-line arguments, allowing the firmware upload to proceed without errors.

Test Scenario
This change has been tested on the following hardware and software configuration:

Hardware: Twin AIoT Module (ESP32-S3-Mini-1 N4R2)

Software: Arduino IDE 2.3.6

Test: A simple "Blink" sketch was successfully compiled and uploaded, confirming that the upload process works as expected.

Copy link
Contributor

github-actions bot commented Sep 26, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix: Add upload flags to boards.txt for Twin AIoT Module to resolve upload error":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello bekirr12, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7533d66

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants