Skip to content

Conversation

xorbit
Copy link
Contributor

@xorbit xorbit commented Sep 27, 2025

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

  • Provide flash size option to choose 4MB flash (rev 5 and below) or 16MB flash (default, rev 7 and higher).
  • Provide appropriate partition scheme options to effectively use either 4MB or 16MB flash sizes.
  • Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and higher default).

Test Scenarios

Tested on Arduino 2.3.6 locally with wESP32 rev 8 board.

- Provide flash size option to choose 4MB flash (rev 5 and below)
  or 16MB flash (default, rev 7 and higher).
- Provide appropriate partition scheme options to effectively us
  either 4MB or 16MB flash sizes.
- Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and
  higher).
@xorbit xorbit requested a review from P-R-O-C-H-Y as a code owner September 27, 2025 00:29
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello xorbit, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e92ad53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant