Skip to content

Commit 8262915

Browse files
songruosongruo
committed
refactor(regi2c): remove regi2c_defs.h from some targets
1 parent 9ef152c commit 8262915

File tree

50 files changed

+112
-954
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+112
-954
lines changed

‎components/esp_hw_support/include/esp_private/regi2c_ctrl.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <stdint.h>
1010
#include "sdkconfig.h"
1111
#include "esp_rom_regi2c.h"
12-
#include "soc/regi2c_defs.h"
1312
#include "soc/soc_caps.h"
1413
#include "esp_private/periph_ctrl.h"
1514
#include "hal/regi2c_ctrl_ll.h"
@@ -20,13 +19,13 @@ extern "C" {
2019

2120
#ifdef BOOTLOADER_BUILD
2221

23-
// For bootloader, the strategy is to keep the analog i2c master clock always enabled if SOC_CLK_ANA_I2C_MST_HAS_ROOT_GATE (in bootloader_hardware_init())
22+
// For bootloader, the strategy is to keep the analog i2c master clock always enabled if ANA_I2C_MST_CLK_HAS_ROOT_GATING (in bootloader_hardware_init())
2423
#define ANALOG_CLOCK_ENABLE()
2524
#define ANALOG_CLOCK_DISABLE()
2625

2726
#else // !BOOTLOADER_BUILD
2827

29-
#if SOC_CLK_ANA_I2C_MST_HAS_ROOT_GATE
28+
#if ANA_I2C_MST_CLK_HAS_ROOT_GATING
3029
// This clock needs to be enabled for regi2c write/read, pll calibaration, PHY, RNG, ADC, etc.
3130
// Use reference count to manage the analog i2c master clock
3231
#define ANALOG_CLOCK_ENABLE() \
@@ -70,6 +69,7 @@ extern "C" {
7069
#define regi2c_ctrl_read_reg_mask regi2c_read_reg_mask_raw
7170
#define regi2c_ctrl_write_reg regi2c_write_reg_raw
7271
#define regi2c_ctrl_write_reg_mask regi2c_write_reg_mask_raw
72+
7373
#define REGI2C_ENTER_CRITICAL()
7474
#define REGI2C_EXIT_CRITICAL()
7575
#else
@@ -106,7 +106,7 @@ void regi2c_exit_critical(void);
106106
* Restore regi2c analog calibration related configuration registers.
107107
* This is a workaround, and is fixed on later chips
108108
*/
109-
#if REGI2C_ANA_CALI_PD_WORKAROUND
109+
#if REGI2C_LL_ANA_CALI_PD_WORKAROUND
110110
void regi2c_analog_cali_reg_read(void);
111111
void regi2c_analog_cali_reg_write(void);
112112
#endif //#if ADC_CALI_PD_WORKAROUND

‎components/esp_hw_support/lowpower/port/esp32c5/sleep_clock.c‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "modem/modem_syscon_reg.h"
1313
#include "modem/modem_lpcon_reg.h"
1414
#include "soc/i2c_ana_mst_reg.h"
15-
#include "soc/regi2c_defs.h"
1615
#include "soc/chip_revision.h"
1716
#include "hal/efuse_hal.h"
1817

‎components/esp_hw_support/lowpower/port/esp32c6/sleep_clock.c‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/*
2-
* SPDX-FileCopyrightText: 2022-2024 Espressif Systems (Shanghai) CO LTD
2+
* SPDX-FileCopyrightText: 2022-2025 Espressif Systems (Shanghai) CO LTD
33
*
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

77
#include "esp_private/sleep_clock.h"
88
#include "soc/pcr_reg.h"
99
#include "soc/pmu_reg.h"
10-
#include "soc/regi2c_defs.h"
10+
#include "soc/i2c_ana_mst_reg.h"
1111
#include "modem/modem_lpcon_reg.h"
1212
#include "modem/modem_syscon_reg.h"
1313

@@ -19,18 +19,18 @@ esp_err_t sleep_clock_system_retention_init(void *arg)
1919

2020
const static sleep_retention_entries_config_t pcr_regs_retention[] = {
2121
/* Enable i2c master clock */
22-
[0] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(0), MODEM_LPCON_CLK_CONF_REG, MODEM_LPCON_CLK_I2C_MST_EN, MODEM_LPCON_CLK_I2C_MST_EN_M, 1, 0), .owner = ENTRY(0) },
22+
[0] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(0), MODEM_LPCON_CLK_CONF_REG, MODEM_LPCON_CLK_I2C_MST_EN, MODEM_LPCON_CLK_I2C_MST_EN_M, 1, 0), .owner = ENTRY(0) },
2323
/* Start BBPLL self-calibration */
24-
[1] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(1), I2C_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
25-
[2] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(2), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_LOW, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
24+
[1] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(1), I2C_ANA_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
25+
[2] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(2), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_LOW, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
2626
/* Wait calibration done */
27-
[3] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(3), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_CAL_DONE, I2C_MST_BBPLL_CAL_DONE, 1, 0), .owner = ENTRY(0) },
27+
[3] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(3), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_CAL_DONE, I2C_MST_BBPLL_CAL_DONE, 1, 0), .owner = ENTRY(0) },
2828
/* Stop BBPLL self-calibration */
29-
[4] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(4), I2C_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
30-
[5] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(5), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_HIGH, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
29+
[4] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(4), I2C_ANA_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
30+
[5] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(5), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_HIGH, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
3131
/* Clock configuration retention */
32-
[6] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(6), DR_REG_PCR_BASE, DR_REG_PCR_BASE, N_REGS_PCR(), 0, 0), .owner = ENTRY(0) | ENTRY(2) },
33-
[7] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(7), PCR_RESET_EVENT_BYPASS_REG, PCR_RESET_EVENT_BYPASS_REG, 1, 0, 0), .owner = ENTRY(0) | ENTRY(2) },
32+
[6] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(6), DR_REG_PCR_BASE, DR_REG_PCR_BASE, N_REGS_PCR(), 0, 0), .owner = ENTRY(0) | ENTRY(2) },
33+
[7] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(7), PCR_RESET_EVENT_BYPASS_REG, PCR_RESET_EVENT_BYPASS_REG, 1, 0, 0), .owner = ENTRY(0) | ENTRY(2) },
3434
};
3535

3636
esp_err_t err = sleep_retention_entries_create(pcr_regs_retention, ARRAY_SIZE(pcr_regs_retention), REGDMA_LINK_PRI_SYS_CLK, SLEEP_RETENTION_MODULE_CLOCK_SYSTEM);

‎components/esp_hw_support/lowpower/port/esp32c61/sleep_clock.c‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "soc/pcr_reg.h"
1010
#include "soc/pmu_reg.h"
1111
#include "soc/i2c_ana_mst_reg.h"
12-
#include "soc/regi2c_defs.h"
1312
#include "modem/modem_lpcon_reg.h"
1413
#include "modem/modem_syscon_reg.h"
1514

‎components/esp_hw_support/lowpower/port/esp32h2/sleep_clock.c‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66

77
#include "esp_private/sleep_clock.h"
88
#include "soc/i2c_ana_mst_reg.h"
9-
#include "soc/regi2c_defs.h"
109
#include "soc/pcr_reg.h"
11-
#include "soc/regi2c_defs.h"
1210
#include "modem/modem_syscon_reg.h"
1311
#include "modem/modem_lpcon_reg.h"
1412

‎components/esp_hw_support/lowpower/port/esp32h21/sleep_clock.c‎

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66

77
#include "esp_private/sleep_clock.h"
88
#include "soc/i2c_ana_mst_reg.h"
9-
#include "soc/regi2c_defs.h"
109
#include "soc/pcr_reg.h"
11-
#include "soc/regi2c_defs.h"
1210
#include "modem/modem_syscon_reg.h"
1311
#include "modem/modem_lpcon_reg.h"
1412

@@ -21,20 +19,20 @@ esp_err_t sleep_clock_system_retention_init(void *arg)
2119

2220
const static sleep_retention_entries_config_t pcr_regs_retention[] = {
2321
/* Enable i2c master clock */
24-
[0] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(0), MODEM_LPCON_CLK_CONF_REG, MODEM_LPCON_CLK_I2C_MST_EN, MODEM_LPCON_CLK_I2C_MST_EN_M, 1, 0), .owner = ENTRY(0) },
22+
[0] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(0), MODEM_LPCON_CLK_CONF_REG, MODEM_LPCON_CLK_I2C_MST_EN, MODEM_LPCON_CLK_I2C_MST_EN_M, 1, 0), .owner = ENTRY(0) },
2523
/* Start BBPLL self-calibration */
26-
[1] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(1), I2C_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
27-
[2] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(2), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_LOW, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
24+
[1] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(1), I2C_ANA_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
25+
[2] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(2), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_LOW, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
2826
/* Wait calibration done */
29-
[3] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(3), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_CAL_DONE, I2C_MST_BBPLL_CAL_DONE, 1, 0), .owner = ENTRY(0) },
27+
[3] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(3), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_CAL_DONE, I2C_MST_BBPLL_CAL_DONE, 1, 0), .owner = ENTRY(0) },
3028
/* Stop BBPLL self-calibration */
31-
[4] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(4), I2C_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
32-
[5] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(5), I2C_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_HIGH, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
29+
[4] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(4), I2C_ANA_MST_ANA_CONF0_REG, 0, I2C_MST_BBPLL_STOP_FORCE_LOW, 1, 0), .owner = ENTRY(0) },
30+
[5] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(5), I2C_ANA_MST_ANA_CONF0_REG, I2C_MST_BBPLL_STOP_FORCE_HIGH, I2C_MST_BBPLL_STOP_FORCE_HIGH, 1, 0), .owner = ENTRY(0) },
3331
/* Clock configuration retention */
34-
[6] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(6), DR_REG_PCR_BASE, DR_REG_PCR_BASE, N_REGS_PCR(), 0, 0), .owner = ENTRY(0) | ENTRY(2) },
35-
[7] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(7), PCR_RESET_EVENT_BYPASS_REG, PCR_RESET_EVENT_BYPASS_REG, 1, 0, 0), .owner = ENTRY(0) | ENTRY(2) },
36-
[8] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(8), PCR_BUS_CLK_UPDATE_REG, PCR_BUS_CLOCK_UPDATE, PCR_BUS_CLOCK_UPDATE_M, 1, 0), .owner = ENTRY(0) | ENTRY(2) },
37-
[9] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(9), PCR_BUS_CLK_UPDATE_REG, 0x0, PCR_BUS_CLOCK_UPDATE_M, 1, 0), .owner = ENTRY(0) | ENTRY(2) },
32+
[6] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(6), DR_REG_PCR_BASE, DR_REG_PCR_BASE, N_REGS_PCR(), 0, 0), .owner = ENTRY(0) | ENTRY(2) },
33+
[7] = { .config = REGDMA_LINK_CONTINUOUS_INIT(REGDMA_PCR_LINK(7), PCR_RESET_EVENT_BYPASS_REG, PCR_RESET_EVENT_BYPASS_REG, 1, 0, 0), .owner = ENTRY(0) | ENTRY(2) },
34+
[8] = { .config = REGDMA_LINK_WRITE_INIT (REGDMA_PCR_LINK(8), PCR_BUS_CLK_UPDATE_REG, PCR_BUS_CLOCK_UPDATE, PCR_BUS_CLOCK_UPDATE_M, 1, 0), .owner = ENTRY(0) | ENTRY(2) },
35+
[9] = { .config = REGDMA_LINK_WAIT_INIT (REGDMA_PCR_LINK(9), PCR_BUS_CLK_UPDATE_REG, 0x0, PCR_BUS_CLOCK_UPDATE_M, 1, 0), .owner = ENTRY(0) | ENTRY(2) },
3836
};
3937

4038
esp_err_t err = sleep_retention_entries_create(pcr_regs_retention, ARRAY_SIZE(pcr_regs_retention), REGDMA_LINK_PRI_SYS_CLK, SLEEP_RETENTION_MODULE_CLOCK_SYSTEM);

‎components/esp_hw_support/port/esp32p4/rtc_clk.c‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -599,9 +599,6 @@ void rtc_clk_mpll_configure(uint32_t xtal_freq, uint32_t mpll_freq, bool thread_
599599
_regi2c_ctrl_ll_master_enable_clock(true);
600600
} else {
601601
ANALOG_CLOCK_ENABLE();
602-
#if !BOOTLOADER_BUILD
603-
regi2c_enter_critical();
604-
#endif
605602
}
606603
/* MPLL calibration start */
607604
regi2c_ctrl_ll_mpll_calibration_start();
@@ -614,9 +611,6 @@ void rtc_clk_mpll_configure(uint32_t xtal_freq, uint32_t mpll_freq, bool thread_
614611
if (thread_safe) {
615612
_regi2c_ctrl_ll_master_enable_clock(false);
616613
} else {
617-
#if !BOOTLOADER_BUILD
618-
regi2c_exit_critical();
619-
#endif
620614
ANALOG_CLOCK_DISABLE();
621615
}
622616
s_cur_mpll_freq = mpll_freq;

‎components/esp_hw_support/regi2c_ctrl.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* SPDX-FileCopyrightText: 2020-2024 Espressif Systems (Shanghai) CO LTD
2+
* SPDX-FileCopyrightText: 2020-2025 Espressif Systems (Shanghai) CO LTD
33
*
44
* SPDX-License-Identifier: Apache-2.0
55
*/
@@ -70,21 +70,21 @@ void regi2c_exit_critical(void)
7070
* Restore regi2c analog calibration related configuration registers.
7171
* This is a workaround, and is fixed on later chips
7272
*/
73-
#if REGI2C_ANA_CALI_PD_WORKAROUND
73+
#if REGI2C_LL_ANA_CALI_PD_WORKAROUND
7474
#include "soc/regi2c_saradc.h"
7575

76-
static DRAM_ATTR uint8_t reg_val[REGI2C_ANA_CALI_BYTE_NUM];
76+
static DRAM_ATTR uint8_t reg_val[REGI2C_LL_ANA_CALI_BYTE_NUM];
7777

7878
void IRAM_ATTR regi2c_analog_cali_reg_read(void)
7979
{
80-
for (int i = 0; i < REGI2C_ANA_CALI_BYTE_NUM; i++) {
80+
for (int i = 0; i < REGI2C_LL_ANA_CALI_BYTE_NUM; i++) {
8181
reg_val[i] = regi2c_ctrl_read_reg(I2C_SAR_ADC, I2C_SAR_ADC_HOSTID, i);
8282
}
8383
}
8484

8585
void IRAM_ATTR regi2c_analog_cali_reg_write(void)
8686
{
87-
for (int i = 0; i < REGI2C_ANA_CALI_BYTE_NUM; i++) {
87+
for (int i = 0; i < REGI2C_LL_ANA_CALI_BYTE_NUM; i++) {
8888
regi2c_ctrl_write_reg(I2C_SAR_ADC, I2C_SAR_ADC_HOSTID, i, reg_val[i]);
8989
}
9090
}

‎components/esp_hw_support/sleep_modes.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
#include "hal/rtc_hal.h"
5858

5959
#include "soc/rtc.h"
60-
#include "regi2c_ctrl.h" //For `REGI2C_ANA_CALI_PD_WORKAROUND`, temp
60+
#include "regi2c_ctrl.h" //For `REGI2C_LL_ANA_CALI_PD_WORKAROUND`, temp
6161

6262
#include "hal/cache_ll.h"
6363
#include "hal/clk_tree_ll.h"
@@ -733,7 +733,7 @@ static SLEEP_FN_ATTR void misc_modules_sleep_prepare(uint32_t sleep_flags, bool
733733
Cache_WriteBack_All();
734734
}
735735
#endif
736-
#if REGI2C_ANA_CALI_PD_WORKAROUND
736+
#if REGI2C_LL_ANA_CALI_PD_WORKAROUND
737737
regi2c_analog_cali_reg_read();
738738
#endif
739739
#if SOC_TEMPERATURE_SENSOR_SUPPORT_SLEEP_RETENTION
@@ -786,7 +786,7 @@ static SLEEP_FN_ATTR void misc_modules_wake_prepare(uint32_t sleep_flags)
786786
clk_ll_soc_root_clk_auto_gating_bypass(true);
787787
# endif
788788
#endif
789-
#if REGI2C_ANA_CALI_PD_WORKAROUND
789+
#if REGI2C_LL_ANA_CALI_PD_WORKAROUND
790790
regi2c_analog_cali_reg_write();
791791
#endif
792792
#if SOC_TEMPERATURE_SENSOR_SUPPORT_SLEEP_RETENTION

‎components/hal/esp32c2/include/hal/regi2c_ctrl_ll.h‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@
1515
extern "C" {
1616
#endif
1717

18+
/**
19+
* Restore regi2c analog calibration related configuration registers.
20+
* This is a workaround for calibration error when waking up from light sleep
21+
*/
22+
#define REGI2C_LL_ANA_CALI_PD_WORKAROUND 1
23+
#define REGI2C_LL_ANA_CALI_BYTE_NUM 8
24+
1825
/**
1926
* @brief Reset (Disable) the I2C internal bus for all regi2c registers
2027
*/

0 commit comments

Comments
 (0)