feat(esp_http_server): Make HTTP(S)_SERVER_EVENT events optional (IDFGH-16707) #17799
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to disable http(s) server events. This improves performance of the server, as http server creates events on every signle read or write to the socket.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 20. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Log |
github-actions
bot
changed the title
mahavirj
reviewed
Nov 13, 2025
|
|
||
| #define ESP_HTTPD_DEF_CTRL_PORT (32768) /*!< HTTP Server control socket port*/ | ||
|
|
||
| #ifdef CONFIG_HTTPD_ENABLE_EVENTS |
Member
There was a problem hiding this comment.
Suggested change
| #ifdef CONFIG_HTTPD_ENABLE_EVENTS | |
| #if CONFIG_HTTPD_ENABLE_EVENTS || __DOXYGEN__ |
| int fd; /*!< Session socket file descriptor */ | ||
| int data_len; /*!< Data length */ | ||
| } esp_http_server_event_data; | ||
| #endif |
Member
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // CONFIG_HTTPD_ENABLE_EVENTS |
| extern "C" { | ||
| #endif | ||
|
|
||
| #ifdef CONFIG_ESP_HTTPS_SERVER_EVENTS |
Member
There was a problem hiding this comment.
Suggested change
| #ifdef CONFIG_ESP_HTTPS_SERVER_EVENTS | |
| #if CONFIG_ESP_HTTPS_SERVER_EVENTS || __DOXYGEN__ |
| HTTPS_SERVER_EVENT_DISCONNECTED, /*!< The connection has been disconnected */ | ||
| HTTPS_SERVER_EVENT_STOP, /*!< This event occurs when HTTPS Server is stopped */ | ||
| } esp_https_server_event_id_t; | ||
| #endif |
Member
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // CONFIG_ESP_HTTPS_SERVER_EVENTS |
| } | ||
| } | ||
| #else | ||
| #define http_dispatch_event_to_event_loop(event_id, event_data, event_data_size) do {} while (0) |
Member
There was a problem hiding this comment.
Could we use similar approach (stub out the implementation) in HTTP server component as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In my quest to improve heap fragmentation, i noticed that the webserver was a big issue, but not for the reasons you think. A single web page read/write causes several esp_events to be sent, each one causing a malloc on its own and a contex switch to handle tasks. And the worst part of it, is that we never listened on any of these events.
This PR adds a KConfig option to disable events on the webserver, this was a hug improvement for us in 5.4.1