Skip to content

Conversation

@TinyuZhao
Copy link
Contributor

@TinyuZhao TinyuZhao commented Nov 6, 2025

Description

Fix: Unable to select a phy interface on ESP32P4

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Add missing break statements in usb_wrap_ll_phy_select to correctly map PHY indices without fallthrough.

Written by Cursor Bugbot for commit 43574a2. This will update automatically on new commits. Configure here.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Tinyu-Zhao, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 43574a2

@github-actions github-actions bot changed the title Fix USB PHY selection logic in usb_wrap_ll.h Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) Nov 6, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 6, 2025
@TinyuZhao TinyuZhao changed the title Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) fix(hal) Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) Nov 6, 2025
@TinyuZhao TinyuZhao changed the title fix(hal) Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) fix(hal): Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) Nov 6, 2025
@tore-espressif
Copy link
Collaborator

sha=43574a2a9276f56c7c2037b85ac6b0f2f4f1b222

@tore-espressif tore-espressif added the PR-Sync-Merge Pull request sync as merge commit label Nov 11, 2025
@tore-espressif
Copy link
Collaborator

@Tinyu-Zhao Thank you for the fix! Will be merged and backported to all active release branches

@TinyuZhao
Copy link
Contributor Author

@Tinyu-Zhao Thank you for the fix! Will be merged and backported to all active release branches

Thank you, I'm also happy to contribute to this project😁

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Nov 11, 2025
@tore-espressif
Copy link
Collaborator

@Tinyu-Zhao your fix was merged internally, thanks! It usually takes few day for the change to appear on GitHub. This PR will be automatically closed when it happens

@espressif-bot espressif-bot merged commit a16739a into espressif:master Nov 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants