-
Notifications
You must be signed in to change notification settings - Fork 8k
fix(hal): Fix USB PHY selection logic in usb_wrap_ll.h (IDFGH-16746) #17831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello Tinyu-Zhao, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
sha=43574a2a9276f56c7c2037b85ac6b0f2f4f1b222 |
|
@Tinyu-Zhao Thank you for the fix! Will be merged and backported to all active release branches |
Thank you, I'm also happy to contribute to this project😁 |
|
@Tinyu-Zhao your fix was merged internally, thanks! It usually takes few day for the change to appear on GitHub. This PR will be automatically closed when it happens |
Description
Fix: Unable to select a phy interface on ESP32P4
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Add missing break statements in usb_wrap_ll_phy_select to correctly map PHY indices without fallthrough.
Written by Cursor Bugbot for commit 43574a2. This will update automatically on new commits. Configure here.