Skip to content

Conversation

@jboynes
Copy link

@jboynes jboynes commented Nov 12, 2025

Adopts approach used by M5GFX that enables/diables output during SPI transaction.

Description

As described in #15510, the M5Stack CoreS3 and CoreS3-SE use GPIO 35 as the MISO line on the peripheral bus and as the D/C output when communicating with the LCD module. This prevents use of the display and SPI peripherals like the W5500 base (and possible the SD card but that's not been tested).

In the M5GFX library, this is worked around by enabling/disabling the D/C output pin alongside CS in cs_control().

This patch adopts the same approach using the pre- and post- transaction callbacks in the LCD panel driver. It enables use of the LCD and W5500 when using the esp-bsp and ESP-IDF components rather then M5Unified (e.g. to use lgvl).

Related

#15510
Potentially esp-bsp #374

Testing

Tested on a CoreS3-SE with the M5Stack PoE LAN base
Without the patch, the w5500 fails to reset, after the patch both LCD and W5500 operate.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Enables the D/C GPIO before SPI transfers and disables it after to prevent conflicts on shared pins (e.g., MISO).

  • Driver: components/esp_lcd/spi/esp_lcd_panel_io_spi.c
    • Pre-transaction (lcd_spi_pre_trans_cb): After setting D/C level, explicitly enable D/C GPIO output via gpio_ll_output_enable(&GPIO, dc_gpio_num).
    • Post-transaction (lcd_spi_post_trans_color_cb): Disable D/C GPIO output via gpio_ll_output_disable(&GPIO, dc_gpio_num) after color transfer completion.

Written by Cursor Bugbot for commit 4dfad2e. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jboynes, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 4dfad2e

@github-actions github-actions bot changed the title fix: IDFGH-14772 where M5Stack CoreS3 uses GPIO 35 for MISO and LCD D/C fix: IDFGH-14772 where M5Stack CoreS3 uses GPIO 35 for MISO and LCD D/C (IDFGH-16776) Nov 12, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 12, 2025
…D D/C

Adopts approach used by M5GFX that enables/diables output during SPI transaction.
@suda-morris
Copy link
Collaborator

sha=4dfad2ecc6fb0114ea7550a08826d71859ebb6b0

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants