Fix typo in cmake docs for EXTRA_COMPONENT_DIRS (IDFGH-16884)#17953
Fix typo in cmake docs for EXTRA_COMPONENT_DIRS (IDFGH-16884)#17953fermino wants to merge 1 commit intoespressif:masterfrom
Conversation
👋 Hello fermino, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
This fixes a typo in a comment that references EXTRA_COMPONENT_DIRS in project.cmake.
| # call later using external COMPONENT_DIRS, COMPONENTS_DIRS, EXTRA_COMPONENTS_DIR, | ||
| # EXTRA_COMPONENTS_DIRS, COMPONENTS, EXLUDE_COMPONENTS, TEST_COMPONENTS, | ||
| # TEST_EXLUDE_COMPONENTS, TESTS_ALL, BUILD_TESTS | ||
| # call later using external COMPONENT_DIRS, COMPONENTS_DIRS, EXTRA_COMPONENT_DIRS, |
There was a problem hiding this comment.
Hello @fermino , I think we can also remove the COMPONENTS_DIRS variable, because I don't see it used anywhere in the build system. It seems only COMPONENT_DIRS is supported. Thank you
I noticed a typo in the comments of
tools/cmake/project.cmakereferencingEXTRA_COMPONENT_DIRS, this fixes it.It's nothing critical at all but it threw me off while digging through the code so here it is :)
Note
Corrects comment in
tools/cmake/project.cmaketo referenceEXTRA_COMPONENT_DIRSconsistently.Written by Cursor Bugbot for commit 1a6e262. This will update automatically on new commits. Configure here.