-
Notifications
You must be signed in to change notification settings - Fork 928
Fix the esp_lcd_dpi_panel_config_t intialization order (AEGHB-1088) #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EK79007_1024_600_PANEL_60HZ_CONFIG initializes the esp_lcd_dpi_panel_config_t in the wrong order, which causes more picky compilers to raise an error.
👋 Hello nicklasb, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
Thank you very much for your fix. This could indeed lead to compilation errors in C++, and we will also apply similar fixes to other drivers in the future. Thanks again for your contribution. |
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sha=47f825fa4a9dc3744646c4fef7fbd420cc4aa66b
|
sha=47f825fa4a9dc3744646c4fef7fbd420cc4aa66b |
EK79007_1024_600_PANEL_60HZ_CONFIG initializes the esp_lcd_dpi_panel_config_t in the wrong order, which causes more picky compilers to raise an error.
Description
The initialization order (and method) of EK79007_1024_600_PANEL_60HZ_CONFIG isn't exactly as the esp_lcd_dpi_panel_config_t type definition, which causes some compilers (or newer ESP-IDF versions) to raise an error about intialization order and completeness, which breaks the build.
This PR corrects the order and adds a matching flags definition.
Checklist
Before submitting a Pull Request, please ensure the following: