Skip to content

Fix the esp_lcd_dpi_panel_config_t intialization order (AEGHB-1088) #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Fix the esp_lcd_dpi_panel_config_t intialization order (AEGHB-1088) #516

merged 1 commit into from
Aug 15, 2025
+4 −4

Conversation

@nicklasb
Copy link
Contributor

@nicklasb nicklasb commented May 19, 2025

EK79007_1024_600_PANEL_60HZ_CONFIG initializes the esp_lcd_dpi_panel_config_t in the wrong order, which causes more picky compilers to raise an error.

Description

The initialization order (and method) of EK79007_1024_600_PANEL_60HZ_CONFIG isn't exactly as the esp_lcd_dpi_panel_config_t type definition, which causes some compilers (or newer ESP-IDF versions) to raise an error about intialization order and completeness, which breaks the build.
This PR corrects the order and adds a matching flags definition.

Checklist

Before submitting a Pull Request, please ensure the following:

  • [ X] 🚨 This PR does not introduce breaking changes.
  • [ TBD] All CI checks (GH Actions) pass.
  • [ X] Documentation is updated as needed.
  • [ X] Tests are updated or added as necessary.
  • [X ] Code is well-commented, especially in complex areas.
  • [ X] Git history is clean — commits are squashed to the minimum necessary.

@nicklasb
Fix the esp_lcd_dpi_panel_config_t intialization order
47f825f 
EK79007_1024_600_PANEL_60HZ_CONFIG  initializes the esp_lcd_dpi_panel_config_t in the wrong order, which causes more picky compilers to raise an error.
@CLAassistant
Copy link

CLAassistant commented May 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented May 19, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix the esp_lcd_dpi_panel_config_t intialization order":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello nicklasb, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 47f825f

@github-actions github-actions bot changed the title Fix the esp_lcd_dpi_panel_config_t intialization order Fix the esp_lcd_dpi_panel_config_t intialization order (AEGHB-1088) May 19, 2025
@Horion0415
Copy link
Contributor

Horion0415 commented Jul 24, 2025

Thank you very much for your fix. This could indeed lead to compilation errors in C++, and we will also apply similar fixes to other drivers in the future. Thanks again for your contribution.

leeebo
leeebo approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha=47f825fa4a9dc3744646c4fef7fbd420cc4aa66b

@leeebo
Copy link
Collaborator

leeebo commented Aug 4, 2025

sha=47f825fa4a9dc3744646c4fef7fbd420cc4aa66b

@zhanzhaocheng zhanzhaocheng merged commit 761e635 into espressif:master Aug 15, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leeebo leeebo leeebo approved these changes

+1 more reviewer

@Horion0415 Horion0415 Horion0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR-Sync-Merge solution: lcd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicklasb @CLAassistant @Horion0415 @leeebo @zhanzhaocheng