-
Notifications
You must be signed in to change notification settings - Fork 928
fix: add #include <stdbool.h> and parentheses (AEGHB-1143) #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log |
leeebo
approved these changes
Jul 23, 2025
Collaborator
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MarcioBulla, the fix looks good to me. Thanks for your contribution!
Collaborator
|
sha=5276b266784ad28c9e6108572a388439fdc7e7ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes compilation errors in the
espressif__knobcomponent.The Clang compiler was producing errors due to incorrect use of the logical NOT operator
!applied directly before a comparison (== 0), which caused ambiguity and warnings treated as errors.To resolve this, parentheses were added around the expression to clarify the intended logic. Additionally, the
<stdbool.h>header was included iniot_knob.hto properly define thebooltype, which was previously causing an unknown type error during compilation.Related
No specific open issues related to this PR.
This PR addresses build errors that prevented using the
espressif__knobcomponent with recent versions of Clang (esp-clang versionesp-18.1.2_20240912).Testing
The firmware was compiled locally using the ESP-IDF toolchain with Clang 18.1.2 without any compilation errors.
The functionality of the
espressif__knobcomponent was tested in the application and behaved as expected.Checklist