-
Notifications
You must be signed in to change notification settings - Fork 927
fix(sensor_hub): Fix compilation issues when using C++ compilers (AEGHB-1200) #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello 1zumIQ, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
| sensor_type_t type; /*!< sensor type */ | ||
| sensor_driver_handle_t (*create)(bus_handle_t, const char *sensor_name, uint8_t addr); /*!< create a sensor */ | ||
| esp_err_t (*delete)(sensor_driver_handle_t *); /*!< delete a sensor */ | ||
| esp_err_t (*remove)(sensor_driver_handle_t *); /*!< delete a sensor */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing delete to remove doesn’t seem to make much difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete is a keyword in cpp, so code that uses it as an identifier will fail to compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the idf_component.yml and CHANGELOG.md files.
- In idf_component.yml, update the version to 0.1.3.
- In CHANGELOG.md, describe the changes introduced in this update.
|
anq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
rename delete to remove to avoid keyword conflict, fix extern "C" block
Description
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: