Skip to content

Conversation

@1zumIQ
Copy link
Contributor

@1zumIQ 1zumIQ commented Aug 29, 2025

rename delete to remove to avoid keyword conflict, fix extern "C" block

Description

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • [*] 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • [*] Documentation is updated as needed.
  • [*] Tests are updated or added as necessary.
  • [*] Code is well-commented, especially in complex areas.
  • [*] Git history is clean — commits are squashed to the minimum necessary.

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(sensor_hub): Fix compilation issues when using C++ compilers":
    • body must have leading blank line

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello 1zumIQ, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 59689d8

@github-actions github-actions bot changed the title fix(sensor_hub): Fix compilation issues when using C++ compilers fix(sensor_hub): Fix compilation issues when using C++ compilers (AEGHB-1200) Aug 29, 2025
sensor_type_t type; /*!< sensor type */
sensor_driver_handle_t (*create)(bus_handle_t, const char *sensor_name, uint8_t addr); /*!< create a sensor */
esp_err_t (*delete)(sensor_driver_handle_t *); /*!< delete a sensor */
esp_err_t (*remove)(sensor_driver_handle_t *); /*!< delete a sensor */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing delete to remove doesn’t seem to make much difference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete is a keyword in cpp, so code that uses it as an identifier will fail to compile.

Copy link
Contributor

@YanKE01 YanKE01 Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the idf_component.yml and CHANGELOG.md files.

  • In idf_component.yml, update the version to 0.1.3.
  • In CHANGELOG.md, describe the changes introduced in this update.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 1zumIQ
❌ anq


anq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants