fix(eppp_link): Fix const qualifier violation in eppp_link (IDFGH-17135) #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed void *ctx parameter to const void *ctx to match esp_netif_find_if API signature that requires const void *ctx in the predicate function.
|
|
sudeep-mohanty
changed the title
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ESP-IDF MR 45069, 45375 enables -Wwrite-strings and -Werror=discarded-qualifiers in ESP-IDF CI builds. This PR fixes const qualifier violations in examples that use espressif/eppp_link managed component causing build failures.
Related
Note
Updates callback signature for const-correctness.
have_some_eppp_netifsecond parameter fromvoid *ctxtoconst void *ctxto align withesp_netif_find_ifusage and eliminate discarded-qualifiers warnings.Written by Cursor Bugbot for commit 712e0a5. This will update automatically on new commits. Configure here.