Skip to content

Detailed error code handling#22

Merged
erhankur merged 1 commit intomasterfrom
feat/spiflash_err_code
Sep 1, 2025
Merged

Detailed error code handling#22
erhankur merged 1 commit intomasterfrom
feat/spiflash_err_code

Conversation

@antmak
Copy link
Copy Markdown
Collaborator

@antmak antmak commented Aug 21, 2025

Cleans up error codes

Assumes error codes will be more specific, allowing the client to get more context about where the error occurred

(Other changes are in the OOCD part)

@antmak antmak changed the base branch from master to feat/spiflash_initial August 21, 2025 18:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello antmak, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a58afdd

@antmak antmak force-pushed the feat/spiflash_initial branch from 45c5776 to bedb2cd Compare August 21, 2025 18:38
@antmak antmak force-pushed the feat/spiflash_err_code branch from 677594d to 914e6d2 Compare September 1, 2025 02:02
@antmak antmak changed the base branch from feat/spiflash_initial to master September 1, 2025 02:03
@antmak antmak requested a review from erhankur September 1, 2025 03:09
@antmak antmak force-pushed the feat/spiflash_err_code branch from 914e6d2 to a58afdd Compare September 1, 2025 08:40
@erhankur erhankur merged commit fa6e250 into master Sep 1, 2025
24 checks passed
@dobairoland dobairoland deleted the feat/spiflash_err_code branch September 15, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants