Skip to content

mem utils, for checking memory range types#25

Merged
antmak merged 2 commits intomasterfrom
feat/mem_utils
Oct 9, 2025
Merged

mem utils, for checking memory range types#25
antmak merged 2 commits intomasterfrom
feat/mem_utils

Conversation

@antmak
Copy link
Collaborator

@antmak antmak commented Sep 1, 2025

Adds helpers for checking some important memory ranges

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Messages
📖 This PR seems to be quite large (total lines of code: 1689), you might consider splitting it into smaller PRs

👋 Hello antmak, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 10b0cfa

@erhankur
Copy link
Collaborator

erhankur commented Sep 2, 2025

Wouldn't be less work if we have a soc header with the memory regions and directly check the regions from one common point? (src/mem_utils.c) We can set missing regions as zero so conditions can be false for non-supported regions.

@antmak antmak marked this pull request as ready for review September 11, 2025 08:42
@antmak antmak requested a review from erhankur October 1, 2025 04:10
Copy link
Collaborator

@erhankur erhankur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@erhankur erhankur requested a review from Copilot October 8, 2025 13:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces memory utility functions to check memory range types across all ESP32 targets. The implementation provides standardized API functions for determining if a given address falls within specific memory regions like IROM, DROM, IRAM, DRAM, RTC memory ranges, and TCM.

  • Adds target-specific memory utility implementations for all ESP32 variants
  • Creates a unified API layer that wraps target-specific functions
  • Provides memory region checking functions for different memory types (ROM, RAM, RTC, TCM)

Reviewed Changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/target/*/src/mem_utils.c Target-specific memory utility implementations
src/target/*/include/soc/soc.h Memory map definitions for each target
src/target/*/CMakeLists.txt Build configuration updates to include mem_utils.c
src/target/common/include/target/mem_utils.h Common header for target-specific functions
src/mem_utils.c Top-level wrapper functions
include/esp-stub-lib/mem_utils.h Public API header with documentation
example/stub_main.c Example usage of the new API
CMakeLists.txt Build configuration update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@antmak antmak merged commit 4de6f9a into master Oct 9, 2025
28 checks passed
@dobairoland dobairoland deleted the feat/mem_utils branch November 28, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants