Conversation
👋 Hello antmak, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
Wouldn't be less work if we have a soc header with the memory regions and directly check the regions from one common point? (src/mem_utils.c) We can set missing regions as zero so conditions can be false for non-supported regions. |
8aa3613 to
c7cd9ba
Compare
03cc7dd to
408a6b6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces memory utility functions to check memory range types across all ESP32 targets. The implementation provides standardized API functions for determining if a given address falls within specific memory regions like IROM, DROM, IRAM, DRAM, RTC memory ranges, and TCM.
- Adds target-specific memory utility implementations for all ESP32 variants
- Creates a unified API layer that wraps target-specific functions
- Provides memory region checking functions for different memory types (ROM, RAM, RTC, TCM)
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/target/*/src/mem_utils.c | Target-specific memory utility implementations |
| src/target/*/include/soc/soc.h | Memory map definitions for each target |
| src/target/*/CMakeLists.txt | Build configuration updates to include mem_utils.c |
| src/target/common/include/target/mem_utils.h | Common header for target-specific functions |
| src/mem_utils.c | Top-level wrapper functions |
| include/esp-stub-lib/mem_utils.h | Public API header with documentation |
| example/stub_main.c | Example usage of the new API |
| CMakeLists.txt | Build configuration update |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds helpers for checking some important memory ranges