-
Notifications
You must be signed in to change notification settings - Fork 184
Add espressif/lan867x driver #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To be able to support Arduino development on the [Silicognition ManT1S](https://www.crowdsupply.com/silicognition/mant1s) board, support for the espressif/lan867x driver first needs to be added to the Arduino Library. Support for the ManT1S can then be added later to the ESP32 Arduino Core. This PR adds generic LAN867x driver support for chips that support the RMII PHY interface (ESP32 and ESP32P4).
I suggest you add this to the Arduino's configuration instead https://github.com/espressif/arduino-esp32/blob/master/idf_component.yml and also add the appropriate changes to the ETH driver (header and implementation) https://github.com/espressif/arduino-esp32/blob/master/libraries/Ethernet/src/ |
Adding it to the Arduino core's Are you seriously suggesting to duplicate the driver code from the ESP Component Registry in the Arduino source, instead of pulling in the existing component? That seems like an absolutely horrible thing to do. |
Nothing of the sort. I do not know why it didn't work for you to add it to Arduino's |
I tried it again and it doesn't work. I even deleted my Added:
to the main arduino-esp32
When I point the What am I missing? I do not understand at which point the Arduino IDE is supposed to go out and get the component from the ESP component registry if it's called out in the main |
you have probably updated the yaml in the wrong Arduino code. You should update the one in your lib-builder/components/Arduino and do the other changes in your |
Ok I think I see. Arduino pulls in a library built from this repo, but building the library pulls in Arduino and its Do you recommend I do a PR in |
Here is the pull request and changes to add support for this chip in Arduino: espressif/arduino-esp32#11843 You should add a new pull request after this one is merged for your board. Make sure that you define this and all other necessary thing for ETH in #define ETH_PHY_TYPE ETH_PHY_LAN867X |
Description
To be able to support Arduino development on the Silicognition ManT1S board, support for the
espressif/lan867x
driver first needs to be added to the Arduino Library.Once the driver is available, support for the ManT1S will be added to the ESP32 Arduino Core.
This PR adds generic LAN867x driver support for chips that support the RMII PHY interface (ESP32 and ESP32P4).
It only touches
main/idf_component.yml
to pull in this component from the ESP Component Registry.Related
Support LAN867x driver already supported in ESP-IDF through the ESP Component Registry.
Testing
It was checked that
espressif/lan867x
lib and include was (only) added toesp32
andesp32p4
output directories.Local build of
esp32-arduino-lib-builder
with this addition was used to build Arduino firmware on local ESP32 Arduino Core patched to support the ManT1S board. Building succeeds and runs ETH_LAN8720 example unmodified when Silicognition ManT1S board is selected (ETH_PHY_MDC is defined for the board in thepins_arduino.h
so the PHY config in the sketch is ignored and the one defined for the board is used).The code runs and produces the expected output when connected to a ManT1S-Bridge to provide Internet access:
Checklist
Before submitting a Pull Request, please ensure the following: