Open
Conversation
|
Download the artifacts for this pull request: |
brianignacio5
force-pushed
the
feature/detect-chip
branch
from
8eb97db to
494c635
Compare
brianignacio5
force-pushed
the
feature/detect-chip
branch
from
63630dd to
c2750cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add get security info detect chip to read IMAGE_CHIP_ID from devices before using magic number as fallback.
This should minimize maintenance of magic number for new chips.
Testing
Ideally you could try testing to connect a board which magic number is not defined in esptool-js magic2Chip function.
Another test is esp32 or esp32s2 will try to connect and run the get security info command, which will fail, and fallback to use the magic number to identify ROM class.
Checklist
Before submitting a Pull Request, please ensure the following: