Skip to content

IEP-1699: Use CDT build environment for idf_tools.py list command#1394

Open
kolipakakondal wants to merge 1 commit intomasterfrom
IEP-1699_new1
Open

IEP-1699: Use CDT build environment for idf_tools.py list command#1394
kolipakakondal wants to merge 1 commit intomasterfrom
IEP-1699_new1

Conversation

@kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Feb 5, 2026

Description

The AbstractToolsHandler.runCommand() was using System.getenv() which only
includes OS system environment variables, but not the CDT build environment
variables set by the IDE (like IDF_TOOLS_PATH).

Fixes # (IEP-1699)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor
    • Improved internal environment setup process to use a unified method for system environment retrieval. No changes to end-user functionality.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

AbstractToolsHandler.java refactored to obtain system environment variables through a centralized IDFEnvironmentVariables().getSystemEnvMap() method instead of directly instantiating a HashMap and capturing System properties. The HashMap import was removed accordingly.

Changes

Cohort / File(s) Summary
Environment Variable Centralization
bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/update/AbstractToolsHandler.java
Replaced direct HashMap-based system environment capture with centralized IDFEnvironmentVariables().getSystemEnvMap() method call; removed unused HashMap import.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • alirana01
  • AndriiFilippov

Poem

🐰 A HashMap once sprawled, now unified and clean,
Environment variables centralize—a harmonious scene,
One method to rule them all, with Python unbuffered flow,
Git PATH adjustments still work, as before we go! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title references IEP-1699 and mentions 'idf_tools.py list command', which aligns with the PR's objective of making this command use CDT build environment variables.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch IEP-1699_new1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kolipakakondal kolipakakondal added this to the v4.2.0 milestone Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant