Skip to content

IEP-1727: Update target platform to Eclipse 2026-03 (4.39) #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigmaaa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

IEP-1727: Update target platform to Eclipse 2026-03 (4.39) #1415

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8880084
feat: update repo versions in target to align with march eclipse release
sigmaaa Mar 18, 2026
87cc4b0
fix: rename commons logging and reset unit versions
sigmaaa Mar 18, 2026
8ff7e41
fix: fixing visual bug in sdkconfig after platform update
sigmaaa Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions releng/com.espressif.idf.target/com.espressif.idf.target.target
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<target name="com.espressif.idf.target" sequenceNumber="25">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/eclipse/updates/4.38"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.39"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
<unit id="org.eclipse.rcp.feature.group" version="0.0.0"/>
<unit id="org.eclipse.test.feature.group" version="0.0.0"/>
Expand All @@ -17,7 +17,7 @@
<unit id="org.eclipse.pde.feature.group" version="0.0.0"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/releases/2025-12/"/>
<repository location="https://download.eclipse.org/releases/2026-03/"/>
<unit id="org.eclipse.cdt.autotools.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.sdk.feature.group" version="0.0.0"/>
Expand All @@ -37,14 +37,14 @@
<unit id="org.apache.log4j" version="0.0.0"/>
<unit id="com.sun.jna" version="0.0.0"/>
<unit id="org.commonmark" version="0.0.0"/> <!-- 0.22.0 -->
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2025-12"/>
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2026-03"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.jgit.feature.group" version="0.0.0"/>
<unit id="org.eclipse.egit.feature.group" version="0.0.0"/>
<unit id="slf4j.api" version="0.0.0"/>
<unit id="slf4j.simple" version="0.0.0"/>
<repository location="https://download.eclipse.org/egit/updates-7.0/"/>
<repository location="https://download.eclipse.org/egit/updates-7.6/"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0"/>
Expand All @@ -64,7 +64,7 @@
<unit id="org.eclipse.embedcdt.packs.feature.group" version="6.4.0.202307251916"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tm4e/releases/0.17.1/"/>
<repository location="https://download.eclipse.org/tm4e/releases/0.17.2/"/>
<unit id="org.eclipse.tm4e.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm4e.language_pack.feature.feature.group" version="0.0.0"/>
</location>
Expand All @@ -73,7 +73,7 @@
<unit id="org.eclipse.justj.openjdk.hotspot.jre.full.feature.group" version="0.0.0"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.4/cdt-lsp-3.4.0/"/>
<repository location="https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.5/cdt-lsp-3.5.0/"/>
<unit id="org.eclipse.cdt.lsp.feature.feature.group" version="0.0.0"/>
<unit id="org.yaml.snakeyaml" version="2.5.0"/>
</location>
Expand All @@ -86,7 +86,7 @@
<unit id="org.eclipse.swtchart.feature.feature.group" version="1.0.0.202412021530"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/lsp4e/releases/0.29.5/"/>
<repository location="https://download.eclipse.org/lsp4e/releases/0.30.0/"/>
Copy link

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for all LSP4E API usages that may be affected
echo "=== LSP4E internal API usage ==="
rg -n "LanguageServiceAccessor|LanguageServerWrapper" --type java -C 3

echo ""
echo "=== All LSP4E imports ==="
rg -n "import.*lsp4e" --type java

echo ""
echo "=== MANIFEST.MF LSP4E version constraints ==="
fd "MANIFEST.MF" --exec grep -l "lsp4" {} \; | xargs -I {} sh -c 'echo "=== {} ===" && grep -E "lsp4[ej]" {}'

Repository: espressif/idf-eclipse-plugin

Length of output: 3603

🌐 Web query:

What API changes were made in Eclipse LSP4E 0.30.0 release?

💡 Result:

The Eclipse LSP4E 0.30.0 release (February 11, 2026) includes the following API changes: - Adaptation to LSP4J version 1.0.0 (PR #1421), which itself has breaking changes such as removal of deprecated APIs, convenience constructors, properties in FormattingOptions, static methods in Either class, and websocket bundle deprecation. - Breaking change: Refactor to get rid of some deprecated APIs (PR #1496 by FlorianKroiss). Specific details on which APIs were removed or refactored are not explicitly listed in the release notes, but it is highlighted under "Breaking changes" in the official GitHub release page. No other explicit public API changes are mentioned in the release notes. The full changelog from 0.29.5 to 0.30.0 can be viewed on GitHub.

Citations:

🏁 Script executed:

# Check full LspService.java content to see `@SuppressWarnings` and method usages
cat -n bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java

Repository: espressif/idf-eclipse-plugin

Length of output: 4280

🏁 Script executed:

# Check for any execute() or restart() method calls
rg -n "\.execute\(\)|\.restart\(\)" bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java -C 2

Repository: espressif/idf-eclipse-plugin

Length of output: 54

🌐 Web query:

Eclipse LSP4E LanguageServiceAccessor API compatibility 0.30.0

💡 Result:

The Eclipse LSP4E LanguageServiceAccessor API is compatible with version 0.30.0. No breaking changes affecting this API are documented in the 0.30.0 release notes. The release includes adaptation to LSP4J 1.0.0 (which has breaking changes like removed deprecated APIs) and removal of some deprecated APIs in LSP4E via PR #1496, but LanguageServiceAccessor is not mentioned as affected. Access to language servers remains available through classes like LanguageServersRegistry and LanguageServers, as shown in source code snippets. Official documentation and changelogs confirm no explicit incompatibility for this API.

Citations:

🌐 Web query:

Eclipse LSP4E LanguageServerWrapper serverDefinition property 0.30.0 breaking changes

💡 Result:

In Eclipse LSP4E version 0.30.0 (released February 11, 2026), the primary breaking change listed in the official release notes is "refactor: Get rid of some deprecated APIs by @FlorianKroiss in #1496". This PR removes usages of deprecated APIs, likely from the newly adopted LSP4J 1.0.0 (feat: Adapt LSP4E to LSP4J vers. 1.0.0 by @travkin79 in #1421), which itself removed several deprecated constructors, static methods, and other APIs. No sources explicitly detail changes to the LanguageServerWrapper.serverDefinition property itself. The property remains public final in LanguageServerWrapper as per available code snippets. Any breaking changes would stem indirectly from LSP4J adaptations or deprecated Eclipse Platform APIs removed in the refactor, potentially affecting custom LanguageServerDefinition implementations if they relied on now-removed deprecated methods. Other changes in 0.30.0 are mostly fixes and features (e.g., SVG icons, JUnit updates, markdown parser singleton), with no other breaking changes noted.

Citations:

🏁 Script executed:

# Check for LSP4J imports and usage in LspService and related files
rg -n "import.*lsp4j|LSP4J" bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/ -A 2

# Check MANIFEST.MF for LSP4J version
cat bundles/com.espressif.idf.core/META-INF/MANIFEST.MF | grep -E "lsp4[ej]|Bundle-"

Repository: espressif/idf-eclipse-plugin

Length of output: 487

🌐 Web query:

Eclipse LSP4J 1.0.0 breaking changes deprecated APIs removal

💡 Result:

Eclipse LSP4J 1.0.0, released February 2026, includes several breaking API changes focused on removing long-deprecated elements and updating to new LSP/DAP specifications. Key breaking changes: - Removed deprecated org.eclipse.lsp4j.websocket bundle. Migrate to org.eclipse.lsp4j.websocket.jakarta or stay on LSP4J 0.x. - Removed deprecated ConcurrentMessageProcessor.startProcessing; use beginProcessing instead (#922). - Removed @Deprecated annotations from members deprecated in LSP/DAP protocols (#895). - Removed various deprecated APIs via issues #874, #875, #876, #877, #880: - #874: General deprecated API removal. - #875: Deprecated convenience constructors in protocol files. - #876: Deprecated LanguageServerAPI annotation (use JsonRpcData). - #877: Deprecated static methods in Either class (use TypeUtils). - #880: Deprecated get/set properties in FormattingOptions. - Type change: TextDocumentEdit.edits from List to List<Either<TextEdit, SnippetTextEdit>>. - Implemented LSP 3.18.0 (beta) and DAP 1.70.0, potentially introducing new structures. Full details in official CHANGELOG.md and japicmp report at https://download.eclipse.org/lsp4j/updates/releases/1.0.0/japicmp-report/. Projects like Spring Tools note API changes requiring updates when migrating to 1.0.0.

Citations:

Update MANIFEST.MF bundle version constraint to match LSP4E target version.

The org.eclipse.lsp4e bundle version in bundles/com.espressif.idf.core/META-INF/MANIFEST.MF is pinned to 0.18.18, which is severely outdated and inconsistent with the LSP4E 0.30.0 target being updated. The constraint should be updated to 0.30.0 to reflect the actual compatibility requirement.

The code in LspService.java uses internal LSP4E APIs (LanguageServiceAccessor.getStartedWrappers(), LanguageServerWrapper.serverDefinition.id, execute(), restart()) marked with @SuppressWarnings("restriction"). These specific APIs are compatible with LSP4E 0.30.0, but keeping the bundle constraint aligned with the target version ensures consistency and clarity about supported versions.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@releng/com.espressif.idf.target/com.espressif.idf.target.target` at line 89,
Update the org.eclipse.lsp4e bundle constraint in the MANIFEST.MF currently
pinned to 0.18.18 to match the target LSP4E version 0.30.0; open the MANIFEST.MF
entry for the org.eclipse.lsp4e bundle
(bundles/com.espressif.idf.core/META-INF/MANIFEST.MF) and change the version
constraint to 0.30.0 so it aligns with the releng target update, ensuring
compatibility with the LspService.java usages of
LanguageServiceAccessor.getStartedWrappers(),
LanguageServerWrapper.serverDefinition.id, execute(), and restart() which rely
on LSP4E 0.30.0 APIs.

<unit id="org.eclipse.lsp4e" version="0.0.0"/>
<unit id="org.eclipse.lsp4e.debug" version="0.0.0"/>
<unit id="org.eclipse.lsp4j" version="0.0.0"/>
Expand Down
Loading