GH #798: At execution Espressif-IDE getting 'Cannot invoke "org.eclipse.debug.core.ILaunchConfiguration.getType()" because "configuration" is null'

[sigmaaa]

Description

The problem was that LaunchBarManager could return null because it was not yet initialized during the eclipse starting phase.

Fixes # (IEP-1002)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Test 1

• run build -> during indexer phase restart eclipse -> after restarting open error log -> should be no NPE exception there

Test 2

• create/clean a workspace -> install tools -> create new project -> create new launch configuration -> should be created correctly. Verify that there is no such error:

Test Configuration:

• ESP-IDF Version:
• OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

• build
• IDFBuildConfiguration

Checklist

• PR Self Reviewed
• Applied Code formatting
• Added Documentation
• Added Unit Test
• Verified on all platforms - Windows,Linux and macOS

[sigmaaa]

added test coverage for ActiveLaunchConfigurationProvider and optimization for IDFBuildConfiguration

[kolipakakondal]

LGTM

[kolipakakondal]

We can avoid referencing internal classes and messages if possible. In this case if we can copy the message and compare it directly

[sigmaaa]

Hi @kolipakakondal, thanks for your feedback. In this case, we rely on this message because it's the name of the Job, so if this message is changed on the eclipse side, this code just won't work and we won't know about it

[AndriiFilippov]

Hi @sigmaaa !

Tested under:

OS - Windows 10
ESP-IDF: v5.1

Test 1 👍
Test 2 👍

Do not see "At execution Espressif-IDE getting 'Cannot invoke "org.eclipse.debug.core.ILaunchConfiguration.getType()" because "configuration" is null'" error, but see this one (probably my local issue):

Error: Cannot invoke "org.eclipse.cdt.core.ICDescriptorManager.addDescriptorListener(org.eclipse.cdt.core.ICDescriptorListener)" because the return value of "org.eclipse.cdt.core.CCorePlugin.getCDescriptorManager()" is null

java.lang.NullPointerException: Cannot invoke "org.eclipse.cdt.core.ICDescriptorManager.addDescriptorListener(org.eclipse.cdt.core.ICDescriptorListener)" because the return value of "org.eclipse.cdt.core.CCorePlugin.getCDescriptorManager()" is null
	at org.eclipse.cdt.internal.core.model.DefaultPathEntryStore.<init>(DefaultPathEntryStore.java:87)
	at org.eclipse.cdt.internal.core.model.PathEntryStoreProxy.createDefaultProvider(PathEntryStoreProxy.java:121)
	at org.eclipse.cdt.internal.core.settings.model.AbstractCExtensionProxy.checkUpdateProvider(AbstractCExtensionProxy.java:102)
	at org.eclipse.cdt.internal.core.settings.model.AbstractCExtensionProxy.doHandleEvent(AbstractCExtensionProxy.java:172)
	at org.eclipse.cdt.internal.core.model.PathEntryStoreProxy.doHandleEvent(PathEntryStoreProxy.java:152)
	at org.eclipse.cdt.internal.core.settings.model.AbstractCExtensionProxy.handleEvent(AbstractCExtensionProxy.java:159)
	at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.notifyListeners(CProjectDescriptionManager.java:2190)
	at org.eclipse.cdt.internal.core.settings.model.AbstractCProjectDescriptionStorage.fireLoadedEvent(AbstractCProjectDescriptionStorage.java:272)
	at org.eclipse.cdt.internal.core.settings.model.xml.XmlProjectDescriptionStorage.getProjectDescription(XmlProjectDescriptionStorage.java:267)
	at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescriptionInternal(CProjectDescriptionManager.java:427)
	at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescription(CProjectDescriptionManager.java:409)
	at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescription(CProjectDescriptionManager.java:403)
	at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescription(CProjectDescriptionManager.java:396)
	at org.eclipse.cdt.internal.core.language.settings.providers.LanguageSettingsScannerInfoProvider.getScannerInformation(LanguageSettingsScannerInfoProvider.java:78)
	at org.eclipse.cdt.internal.core.language.settings.providers.LanguageSettingsScannerInfoProvider.getScannerInformation(LanguageSettingsScannerInfoProvider.java:1)
	at org.eclipse.cdt.internal.core.model.TranslationUnit.getScannerInfo(TranslationUnit.java:1070)
	at org.eclipse.cdt.internal.core.pdom.indexer.ProjectIndexerInputAdapter.getBuildConfiguration(ProjectIndexerInputAdapter.java:160)
	at org.eclipse.cdt.internal.core.pdom.AbstractIndexerTask.getScannerInfo(AbstractIndexerTask.java:1030)
	at org.eclipse.cdt.internal.core.pdom.AbstractIndexerTask.parseLinkage(AbstractIndexerTask.java:909)
	at org.eclipse.cdt.internal.core.pdom.AbstractIndexerTask.runTask(AbstractIndexerTask.java:572)

[kolipakakondal]

Hi @sigmaaa Please verify @AndriiFilippov comments and see if that's an issue. I've merging this PR since I have NPE issue while adding clang toolchain