Skip to content

feat(libsodium): add support for PSA crypto APIs #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahavirj merged 1 commit into from
Jan 9, 2026
Merged

feat(libsodium): add support for PSA crypto APIs #656

mahavirj merged 1 commit into from
Jan 9, 2026
+184 −4

Conversation

@mahavirj
Copy link
Member

@mahavirj mahavirj commented Jan 2, 2026

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@github-actions
Copy link

github-actions bot commented Jan 2, 2026 •
edited
Loading

Test Results

40 files  40 suites   4m 2s ⏱️
23 tests 11 ✅ 11 💤 0 ❌ 1 🔥
90 runs  22 ✅ 64 💤 0 ❌ 4 🔥

For more details on these errors, see this check.

Results for commit 3b7df17.

♻️ This comment has been updated with latest results.

@mahavirj mahavirj requested review from Ashish285 and Copilot January 5, 2026 09:06
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for PSA crypto APIs to the libsodium component, enabling compatibility with mbedTLS 4.x. The implementation provides conditional compilation to maintain backward compatibility with earlier mbedTLS versions.

Key Changes:

  • Add PSA crypto API implementations for SHA256 and SHA512 hash functions
  • Introduce conditional compilation based on CONFIG_MBEDTLS_VER_4_X_SUPPORT flag
  • Add automatic PSA crypto initialization via constructor functions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.

File Description
libsodium/port/crypto_hash_mbedtls/crypto_hash_sha512_mbedtls.c Adds PSA crypto API support for SHA512 hashing with conditional compilation for mbedTLS 4.x
libsodium/port/crypto_hash_mbedtls/crypto_hash_sha256_mbedtls.c Adds PSA crypto API support for SHA256 hashing with conditional compilation for mbedTLS 4.x

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahavirj mahavirj force-pushed the feat/libsodium_psa_support branch from eb843d6 to c31079d Compare January 7, 2026 10:45
@mahavirj mahavirj requested a review from Copilot January 7, 2026 10:45
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahavirj mahavirj force-pushed the feat/libsodium_psa_support branch from c31079d to c45952c Compare January 7, 2026 11:10
@mahavirj mahavirj requested a review from Copilot January 7, 2026 11:10
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahavirj mahavirj force-pushed the feat/libsodium_psa_support branch from c45952c to db23a71 Compare January 8, 2026 06:50
Ashish285
Ashish285 reviewed Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@Ashish285 Ashish285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments regarding checking the incoming pointers. Otherwise LGTM!

@mahavirj mahavirj force-pushed the feat/libsodium_psa_support branch from db23a71 to 3b7df17 Compare January 9, 2026 12:44
@mahavirj mahavirj merged commit d7f2dce into master Jan 9, 2026
162 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ashish285 Ashish285 Ashish285 left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahavirj @Ashish285