Add Lua component (IEC-470) #658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
suda-morris
reviewed
Jan 9, 2026
suda-morris
reviewed
Jan 9, 2026
lua/include/luaconf.h
Outdated
| /* | ||
| @@ LUA_32BITS enables Lua with 32-bit integers and 32-bit floats. | ||
| */ | ||
| #define LUA_32BITS 1 |
Collaborator
There was a problem hiding this comment.
I think we don't have to fork the whole header file, can we try other header injection approach?
Author
There was a problem hiding this comment.
Good idea. Replaced by lua/port/include/luaconf.h
suda-morris
reviewed
Jan 9, 2026
suda-morris
reviewed
Jan 9, 2026
lua/include/luaconf.h
Outdated
| ** (It must fit into max(int)/2.) | ||
| */ | ||
| #if 1000000 < (INT_MAX / 2) | ||
| #define LUAI_MAXSTACK CONFIG_LUA_MAXSTACK |
Collaborator
There was a problem hiding this comment.
this macro isn't available in the upstream https://github.com/lua/lua/blob/master/luaconf.h
Author
|
All builds are green, just one is failing in picolib with from ESP-IDF, I guess this is not specific to this component: Any idea how to resolve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lua component is getting popular, so idea is to move it under Espressif namespace.
Formerly it was hosted here: https://github.com/georgik/esp-idf-component-lua
Component Registry: https://components.espressif.com/components/georgik/lua/