Skip to content

fix(esp_cli_commands): static analyzer warnings#688

Merged
SoucheSouche merged 1 commit intoespressif:masterfrom
SoucheSouche:fix/esp-cli-commands-static-analyzer-warnings
Feb 24, 2026
Merged

fix(esp_cli_commands): static analyzer warnings#688
SoucheSouche merged 1 commit intoespressif:masterfrom
SoucheSouche:fix/esp-cli-commands-static-analyzer-warnings

Conversation

@SoucheSouche
Copy link
Collaborator

Checklist

  • CI passing

Change description

  • update call_completion_cb to make sure the buffer has a smaller size than the command name it compares to in the strncmp function call
  • update esp_cli_dynamic_commands_replace to actually fetch the list item of the old command and copy the new command to override the old command

- update call_completion_cb to make sure the buffer has a smaller size
than the command name it compares to in the strncmp function call
- update esp_cli_dynamic_commands_replace to actually fetch the list
item of the old command and copy the new command to override the old
command
Copy link
Collaborator

@ESP-Marius ESP-Marius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoucheSouche SoucheSouche merged commit a6b5793 into espressif:master Feb 24, 2026
160 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants