fix(spi_nand_flash): spi_nand_program_load fails if buffer is not DMA aligned#700
Conversation
3ab4a5c to
ec6d455
Compare
|
Left 2 minor comment, PTAL |
369008a to
e3b5e57
Compare
|
Fixed. PTAL. Thank you! |
b2cee4b to
54e0e68
Compare
|
AI generated review, PTAL: 1. Linux build:
|
| # | Severity | Item |
|---|---|---|
| 1 | Critical | Linux build can fail: esp_memory_utils.h needs SOC_DMA_*; guard include/use or add Linux soc stubs. |
| 2 | Minor | CHANGELOG: single-line entry and single blank line between version blocks. |
| 3 | Medium | spi_nand_oper.h: add extern "C" for C++ inclusion. |
| 4 | Verify | nand.c: ensure CONFIG_IDF_TARGET_LINUX is defined when expected. |
eb9d580 to
8f22bc2
Compare
Additionally, for host_tests, there is no need for a fatfs dependency. In fact, the spi_nand_flash component itself does not require a fatfs dependency. I will remove this dependency in a following MR. For now, it has only been updated for host-specific builds. |
8f22bc2 to
698dd74
Compare
698dd74 to
9cda83d
Compare
pacucha42
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing my and AI comments
Change description
Fix failure in spi_nand_program_load when the input buffer is not DMA-aligned.
Mainly it handles-
Closes #684