feat(thorvg): update ThorVG to version 1.0.1#701
Merged
suda-morris merged 1 commit intoespressif:masterfrom Mar 16, 2026
Merged
feat(thorvg): update ThorVG to version 1.0.1#701suda-morris merged 1 commit intoespressif:masterfrom
suda-morris merged 1 commit intoespressif:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the ThorVG wrapper/component and example to ThorVG v1.0.1, aligning build integration and the Lottie example with the ThorVG 1.x C API and runtime behavior.
Changes:
- Updated ThorVG submodule + component/SBOM metadata to v1.0.1.
- Adjusted wrapper build system (loader options, static lib byproduct path, warning handling).
- Migrated
thorvg_lottieexample to ThorVG 1.x API and moved rendering into a pthread with semaphore-based flush synchronization.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| thorvg/thorvg | Updates ThorVG git submodule commit to v1.0.1 revision. |
| thorvg/sbom_thorvg.yml | Synces SBOM version/hash with the updated submodule. |
| thorvg/idf_component.yml | Bumps component version and updates documentation link. |
| thorvg/examples/thorvg_lottie/sdkconfig.defaults.esp32s3 | Updates ESP32-S3 example defaults (CPU freq / WDT-related settings changed). |
| thorvg/examples/thorvg_lottie/sdkconfig.defaults | Adjusts example sdkconfig defaults (removes main task stack override). |
| thorvg/examples/thorvg_lottie/main/thorvg_example_main.c | Migrates example to ThorVG 1.x API and adds pthread render loop + semaphore sync. |
| thorvg/examples/thorvg_lottie/main/CMakeLists.txt | Adds pthread dependency for the example. |
| thorvg/cross_file.txt.in | Updates Meson cross compile flags (removes some suppressions). |
| thorvg/Kconfig | Removes TVG loader Kconfig option consistent with ThorVG 1.x loader handling. |
| thorvg/CMakeLists.txt | Updates library path/byproduct and refactors loader options; adds warning suppression. |
Comments suppressed due to low confidence (1)
thorvg/examples/thorvg_lottie/main/thorvg_example_main.c:1
- The semaphore wait ordering allows a new
esp_lcd_panel_draw_bitmap()to be started without first ensuring the previous transfer is complete in a couple of cases: (1) the initial 'background black' flush is issued without any semaphore gate, and (2) the last frame'sdraw_bitmap()isn't waited on before cleanup/return. This can overlap transfers acrossplay_lottie()calls and/or reuse buffers while a transfer is still in progress. Consider gating everydraw_bitmap()by taking the semaphore immediately before starting a transfer (and making the semaphore initially available), and also waiting once after the finaldraw_bitmap()before returning.
/*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What Changed
Breaking Changes