Skip to content

Conversation

@fhrbata
Copy link
Collaborator

@fhrbata fhrbata commented Feb 11, 2025

  • Pillow needs libjpeg-dev
  • ruamel.yaml.clib 0.2.8 does not support python 3.13

Description

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@fhrbata fhrbata marked this pull request as draft February 11, 2025 13:08
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello fhrbata, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 16ee490

* Pillow needs libjpeg-dev
* ruamel.yaml.clib 0.2.8 does not support python 3.13

Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
@fhrbata fhrbata force-pushed the fix/dependent_wheels branch 2 times, most recently from ef7603c to 16ee490 Compare February 11, 2025 17:48
@fhrbata fhrbata self-assigned this Feb 11, 2025
@fhrbata fhrbata marked this pull request as ready for review February 11, 2025 17:50
@fhrbata fhrbata requested a review from dobairoland February 11, 2025 17:50
@fhrbata
Copy link
Collaborator Author

fhrbata commented Feb 11, 2025

I tested it locally with ubuntu:latest and x86_64 and also manually started the platforms-dispatches workflow for the branch here https://github.com/espressif/idf-python-wheels/actions/runs/13264807493. It seems to be working so far.

Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dobairoland dobairoland merged commit ed715a1 into main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants