Skip to content

Conversation

@dobairoland
Copy link
Collaborator

esptool.py version installed from the 4.9.1 wheel produces the following error:
ModuleNotFoundError: No module named 'esptool.init'; 'esptool' is not a package

The issue is not present if the package is installed from tar.gz.

pytest-embedded is also broken because of this issue.

See also espressif/esptool#1107.

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello dobairoland, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 217cd7c

@dobairoland dobairoland force-pushed the change/exclude_esptool branch from 4b6cd9d to 217cd7c Compare August 2, 2025 16:11
esptool.py version installed from the 4.9.1 wheel produces the following
error:
ModuleNotFoundError: No module named 'esptool.__init__'; 'esptool' is not a package

The issue is not present if the package is installed from tar.gz.

pytest-embedded is also broken because of this issue.

See also espressif/esptool#1107.
Copy link
Collaborator

@fhrbata fhrbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for taking care of this!

@jakub-kocka
Copy link
Collaborator

LGTM! Thank you.

@dobairoland dobairoland merged commit 14991dd into main Aug 4, 2025
1 check passed
@dobairoland dobairoland deleted the change/exclude_esptool branch August 4, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants