Skip to content

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.13.3 → v0.14.10](astral-sh/ruff-pre-commit@v0.13.3...v0.14.10)
- [github.com/pre-commit/mirrors-mypy: v1.18.2 → v1.19.1](pre-commit/mirrors-mypy@v1.18.2...v1.19.1)
- [github.com/espressif/conventional-precommit-linter: v1.10.0 → v1.11.0](espressif/conventional-precommit-linter@v1.10.0...v1.11.0)
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "ci: Bump pre-commit hooks":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello pre-commit-ci[bot], we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against db8777c

@github-actions github-actions bot changed the title ci: Bump pre-commit hooks ci: Bump pre-commit hooks (IDFGH-17038) Jan 5, 2026
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 5, 2026
@jakub-kocka
Copy link
Collaborator

We won't be doing this until we drop the support for Python 3.8, since the targeted version of mypy requires Python >= 3.9

I am leaving this open to avoid another open by the pre-commit ci

@jakub-kocka jakub-kocka added the Resolution: Won't Do Issue will not be worked on label Jan 6, 2026
@dobairoland
Copy link
Collaborator

@jakub-kocka You can add with the skip keyword a restriction to avoid updating mypy. I would add such a comment there which would be easily found when you will searching for places while dropping the 3.8 support.

Keeping this and internal trackers seems to me a waste of time (from the perspective of managing open tickets).

@jakub-kocka
Copy link
Collaborator

It will be resolved in this PR: #56

@jakub-kocka jakub-kocka closed this Jan 7, 2026
@espressif-bot espressif-bot added Status: In Progress Issue is being worked on and removed Status: Opened Issue is new labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Resolution: Won't Do Issue will not be worked on Status: In Progress Issue is being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants