[Xtensa] Fix .set symbolic constants in b4const/b4constu immediates#124
Open
MabezDev wants to merge 1 commit intoespressif:release/esp_21.xfrom
Open
[Xtensa] Fix .set symbolic constants in b4const/b4constu immediates#124MabezDev wants to merge 1 commit intoespressif:release/esp_21.xfrom
MabezDev wants to merge 1 commit intoespressif:release/esp_21.xfrom
Conversation
Use parseExpression() for identifier tokens in parseImmediate() instead of manually creating MCSymbolRefExpr. This allows parsePrimaryExpr to inline .set symbols defined as MCConstantExpr values, which is needed for b4const/b4constu operand validation in branch instructions like bnei, beqi, bgei, blti, bgeui, and bltui. Without this, assembly using `.set CONST, 4` followed by `bnei a6, CONST, label` fails with "expected b4const immediate" because the operand is an unresolved MCSymbolRefExpr rather than an MCConstantExpr.
Author
|
Resolves esp-rs/esp-hal#5110 (comment) but feel free to take this patch and implement it in a better way, if you see fit. |
Author
|
It wasn't an issue in 20.x, so perhaps a rebase issue? |
Collaborator
Yes, you right, this is rebase issue, Thank you for reporting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.