Merged
Conversation
horw
force-pushed
the
feat/test-supported-targets
branch
from
1b2c762 to
440c18e
Compare
horw
commented
Feb 18, 2025
hfudev
reviewed
Feb 18, 2025
Member
There was a problem hiding this comment.
your current approach would process this env var again and again in each test case. it's better to do it in a global contextvar. https://docs.python.org/3/library/contextvars.html
horw
force-pushed
the
feat/test-supported-targets
branch
from
440c18e to
7dceaa7
Compare
horw
force-pushed
the
feat/test-supported-targets
branch
from
7dceaa7 to
fc7f3bd
Compare
hfudev
reviewed
Feb 18, 2025
hfudev
reviewed
Feb 19, 2025
Member
hfudev
left a comment
hfudev
left a comment
There was a problem hiding this comment.
LGTM. comments are only about docs and help messages
horw
force-pushed
the
feat/test-supported-targets
branch
from
0ffac0e to
fff28ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to propagate supported targets and preview targets with ContextVars.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: