fix(pytest-embedded-qemu): Allowed QEMU RISCV flash image sizes (RDT-1177)#344
Merged
hfudev merged 1 commit intoespressif:mainfrom Mar 3, 2025
Merged
Conversation
Member
|
LGTM. Thank you for the fix! |
Member
|
At this point, does it make sense to keep the supported flash sizes list different between Xtensa and RISC-V? In QEMU, support of flash size for the specific machine is anyways implemented in each machine's source file, not once per architecture. So even for the same architecture, the lists could be different... So if we are making the lists different, then one list per target would make more sense than one per architecture. |
Contributor
Author
True! |
Member
|
@igrr I'll check how to improve this. Thanks for your insights! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running a pytest test case using QEMU for ESP32-C3, produces the following error:
ESP32-C3 (riscv) QEMU seems to support only 2, 4, 8, and 16MB flash image sizes reference.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: