feat: get targets filtered by soc attrs#345
Merged
hfudev merged 1 commit intoespressif:mainfrom Mar 12, 2025
Merged
Conversation
Collaborator
Author
|
@hfudev Hello! What do you think about this function? Should we add it to our utils or not, since we already have the supported_targets and preview_targets logic, getting the filtered target is quite easy. |
Member
|
I think it's a nice feature to have! Thank you for your idea. could you check why the test cases are failing? I somehow assume that those are runner issues but could you double check. if all looks good I'll merge it |
Collaborator
Author
You are right; the failed test case is related to the target running test. Not for this PR. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, a function is added that will return a target list according to the SOC_CAPS attribute. We already have
skip_if_soc, but in some cases, it is better to directly filter by target rather than adding a skip mark for it.Related
Testing
The
test_soc_filtered_targetswas added.Checklist
Before submitting a Pull Request, please ensure the following: