Skip to content

feat: get targets filtered by soc attrs#345

Merged
hfudev merged 1 commit intoespressif:mainfrom
horw:feat/soc_filtered_targets
Mar 12, 2025
Merged

feat: get targets filtered by soc attrs#345
hfudev merged 1 commit intoespressif:mainfrom
horw:feat/soc_filtered_targets

Conversation

@horw
Copy link
Copy Markdown
Collaborator

@horw horw commented Mar 12, 2025

Description

In this PR, a function is added that will return a target list according to the SOC_CAPS attribute. We already have skip_if_soc, but in some cases, it is better to directly filter by target rather than adding a skip mark for it.

Related

Testing

The test_soc_filtered_targets was added.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@horw horw requested a review from hfudev March 12, 2025 07:11
@horw
Copy link
Copy Markdown
Collaborator Author

horw commented Mar 12, 2025

@hfudev Hello! What do you think about this function? Should we add it to our utils or not, since we already have the supported_targets and preview_targets logic, getting the filtered target is quite easy.

@hfudev
Copy link
Copy Markdown
Member

hfudev commented Mar 12, 2025

I think it's a nice feature to have! Thank you for your idea.

could you check why the test cases are failing? I somehow assume that those are runner issues but could you double check.

if all looks good I'll merge it

@horw
Copy link
Copy Markdown
Collaborator Author

horw commented Mar 12, 2025

could you check why the test cases are failing? I somehow assume that those are runner issues but could you double check.

You are right; the failed test case is related to the target running test. Not for this PR.

@hfudev hfudev merged commit 8b64c3b into espressif:main Mar 12, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants