feat: use baudrate from EspSerial in EspNuttx (RDT-1275)#352
Merged
hfudev merged 1 commit intoespressif:mainfrom Apr 17, 2025
Merged
Conversation
Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the NuttxSerial class.
It had a fixed flash baud rate (for Espressif devices) and now it can be changed through the command line. It simply removes the custom entry for baud rate and uses the baud from the inherited EspSerial class.
Related
Testing
Tested by running Pytest without setting
--esptool-baudand than by setting to a customized value.The flash is first erased and then the firmware is uploaded. Baud rate line is marked.
esptool-baud:--esptool-baud=460800:Checklist
Before submitting a Pull Request, please ensure the following: