Merged
Conversation
hfudev
force-pushed
the
feat/esptool-5-compatible
branch
from
a6ddf2d to
b8bf288
Compare
Member
Author
|
I'll merge this PR and release a dev version for testing in esp-idf |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to be compatible with esptool version 5 while maintaining backwards compatibility. The changes include conditional dependency management based on Python version and test adjustments to accommodate new esptool behavior.
- Updates esptool dependency to support version 5 for Python 3.10+ while keeping version 4 for older Python versions
- Adjusts test expectations to work with both esptool versions
- Configures pytest to handle warnings and adds CI workflow improvements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pytest-embedded-serial-esp/pyproject.toml | Splits esptool dependency by Python version to support both v4 and v5 |
| pytest-embedded-idf/tests/test_idf.py | Updates test expectation to match new esptool output format |
| pyproject.toml | Adds pytest configuration for warnings and junit format |
| .github/workflows/test-python.yml | Extends CI trigger to include pyproject.toml changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #361