fix(esp): deprecate warnings raised by esptool 5#363
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes deprecation warnings raised by esptool version 5 by updating argument formatting in the flash method. The change ensures compatibility with newer esptool versions that expect hyphenated argument names instead of underscored ones.
Key Changes
- Modified argument formatting in the IDF serial flash method to replace underscores with hyphens in command-line arguments
| _args.append(f'--{k}') | ||
| else: | ||
| _args.append(f'--{k}') | ||
| _args.append(f'--{k.replace("_", "-")}') |
There was a problem hiding this comment.
The blanket replacement of underscores with hyphens may cause issues for argument keys that legitimately contain underscores as part of their expected format. Consider implementing a more targeted approach that only converts specific known arguments or validates against a whitelist of expected esptool arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.