fix(qemu): set qemu_proj_path for QemuApp correctly#367
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the qemu_prog_path property in the QemuApp class by converting it from a property to an instance attribute that can be set during initialization. This allows users to specify a custom QEMU program path when creating a QemuApp instance.
- Converts
qemu_prog_pathfrom a computed property to a configurable instance attribute - Adds a new optional parameter
qemu_prog_pathto the__init__method - Sets the attribute during initialization with fallback to the default format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1 task
682aa5c to
05af5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #366