Skip to content

revert: esptool 5 requirements. will do it in pytest-embedded 2.x#370

Merged
hfudev merged 1 commit intomainfrom
revert-esptool
Sep 8, 2025
Merged

revert: esptool 5 requirements. will do it in pytest-embedded 2.x#370
hfudev merged 1 commit intomainfrom
revert-esptool

Conversation

@hfudev
Copy link
Member

@hfudev hfudev commented Sep 8, 2025

No description provided.

@hfudev hfudev requested a review from Copilot September 8, 2025 12:20
@hfudev hfudev self-assigned this Sep 8, 2025
@hfudev hfudev marked this pull request as ready for review September 8, 2025 12:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes related to esptool version 5 requirements, postponing this upgrade to pytest-embedded 2.x. The changes simplify dependency management by removing Python version-specific esptool requirements and fix a parameter formatting issue.

  • Reverts esptool dependency to a single version constraint (~=4.9) instead of Python version-specific requirements
  • Fixes argument formatting in the flash function by removing underscore-to-hyphen replacement

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pytest-embedded-serial-esp/pyproject.toml Simplifies esptool dependency from version-specific constraints to single ~=4.9 requirement
pytest-embedded-idf/pytest_embedded_idf/serial.py Removes underscore-to-hyphen replacement in argument formatting for flash function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hfudev hfudev merged commit 162abd3 into main Sep 8, 2025
3 of 7 checks passed
@hfudev hfudev deleted the revert-esptool branch September 8, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants