Conversation
7dc64f9 to
73bd4d8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the multiprocessing implementation to always use the spawn context instead of platform-specific contexts, which addresses stability issues and ensures consistent behavior across platforms.
- Replaces platform-specific multiprocessing context selection with unified spawn context
- Consolidates MessageQueue implementation and moves it to the main module with proper manager support
- Removes unstable test marker and updates fixture dependencies
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pytest-embedded/__init__.py |
Introduces centralized MP_CTX using spawn context and consolidated MessageQueue/MessageQueueManager classes |
pytest-embedded/plugin.py |
Updates fixture to use new MessageQueueManager and adds proper MessageQueue cleanup handling |
pytest-embedded/log.py |
Removes old MessageQueue implementation and platform-specific context, imports from main module |
pytest-embedded/dut_factory.py |
Updates imports and removes old context/queue generator functions |
pytest-embedded/dut.py |
Updates type hint to use proper MessageQueue type |
tests/test_base.py |
Removes xfail marker from previously unstable test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
73bd4d8 to
387b877
Compare
Member
Author
|
Tested locally on macOS, all tests are passing. On Windows, tests are still failing (also failing with the current 1.17.0 version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #294