Conversation
|
Download the artifacts for this pull request: |
|
Hi, I noticed this PR has been open for about three weeks. May I ask when we can expect the official release of V2.0? Thank you for your work! |
|
Pull request has been marked as |
8b401ec to
4633597
Compare
|
Pull request has been marked as |
6e30aee to
36d2b19
Compare
* draft eim integration * update init extension auto config * rm global state idf setups * do not show invalid extension when showOnboardingOnInit is false * rm duplicate code * update welcome show * fix new projext examples esp idf loading * update default esp_ide json file * add eim verify idf setup functions * update to eim_idf json file name * save settings as env variables * rm settings use customExtraVars instead * fix save docker settings * check empty customExtraVars PATH * fix getConfigurationSettings * rm old setup * fix lint * rm setup webpack update python in project test * use customextravars first * add selected workspace global config * use process env if customextra vars not available * default tools path * test doctor command * write customExtraVars from process env if available * fix workspace arg * update menuconfig test rm doc cmd * add PYTHON env var * log doctor command output clean project first * add missing timeout * test debug vscode * add PYTHON env var * add env PYTHON save settings * fallback on global state setups * escape activation script path if spaces * move IDF_PATH to workspace state, move frameworks settings to customExtraVars * update rm global setups * use env vars if idfSetups not defined, rm redudant code downloadManager and tests * read esp idf setups from esp_idf.json * await getConfigurationAccess * add logger init * fix IDF_TOOLS_PATH not defined if default * add PYTHON to env variables * change checkIdfSetup to isIdfSetupValid rm IEspIdfTool fields * remove env systemDriver use C in Windows default eim_idf json path * log activation script output * change to error logs * update activationScript split regex * fix IDF_PYTHON_ENV_PATH to envDict * loadIdfSetup save idf.gitPath * add path to prepareEnv * fix idf size ui * add idf setups in doctor command * add validation for eim load env setup * idfSetupToUse add validation * fix load idf.currentSetup * rm idf.espIdfPath from docs rm duplicate idfSetups use old idf.espIdfPath if no idf.currentSetup * add download extract install run eim from extension * fx linux exe call * use env shell for activation script * allow pick mirror eim download, add l10n for msg * fix errors * fix env vars in clang validate * use latest vscode-extension-tester * use eimPath field in eim_idf json to open existing executable if exists * rm idf setup validation, only in doctor cmd * fix checkPyVenv object * rm idf.toolsPath reference * use idf toolsPath old setting to find esp_idf json file * rm use of ESP_IDF_VERSION in status bar * add missing v for idf version * update walkthrough install step * add idf.eimExecutableArgs for eim gui or cli * use & intead of launch process * make sure that eim_unified_release is not cached, rm quote * close notifications befor doctor cmd * mv dismiss to before * fix lint * fix ts issues * use default tools path instead of temp for eim download * add default EIM locations to match Espressif IDE and use EIM_PATH * test json reporter no use of docker * add expected test env vars * add results in console too, rm actions idf fix doctor test * replace user path in doctor test * test using e2e ui reports * test extester mocha options * update options as object * update reporter option * try to parse json from console * fix console output parsing * update console output parse error handle * clean json step * update test log to test locally * rm text after closing json * update end regex * update parsing with test data * fail on test error * update bulma packages and use new syntax
36d2b19 to
7834a5b
Compare
Fabricio-ESP
left a comment
There was a problem hiding this comment.
Confirmed working. Tested with EIM release 0.7.1
No issues found on regular customer use cases.
docs_espressif/en/installation.rst
Outdated
| - Navigate to ``View`` > ``Command Palette``. | ||
|
|
||
| - Type ``ESP-IDF: Configure ESP-IDF Extension`` and select the command to launch the setup wizard. A loading notification will appear, followed by the setup wizard. | ||
| - Type ``ESP-IDF: Open ESP-IDF Install Manager`` to download and run the ESP-IDF install manager to install the ESP-IDF framework. A loading notification will appear, followed by the execution of the installer. |
There was a problem hiding this comment.
"ESP-IDF Installation Manager"
To follow the same name indicated on the EIM webpage.
I noticed that the command itself has a different name from the command palette or the explorer panel.
docs_espressif/en/installation.rst
Outdated
| .. image:: ../../media/tutorials/setup/select-mode.png | ||
|
|
||
| 2. Choose ``Express`` and select the download server: | ||
| 2. Alternatively, you can download the ESP-IDF Install Manager from the following link `ESP-IDF Install Manager <https://dl.espressif.com/dl/eim/index.html>`_ among the following options: |
There was a problem hiding this comment.
"ESP-IDF Installation Manager"
docs_espressif/en/installation.rst
Outdated
| - ESP-IDF download progress | ||
| - ESP-IDF Tools download and installation progress | ||
| - Creation of a Python virtual environment and installation of ESP-IDF Python requirements | ||
| 3. Use the ESP-IDF Install Manager to install the ESP-IDF and tools. If necessary, here is the `ESP-IDF Install Manager Documentation <https://docs.espressif.com/projects/idf-im-ui/en/latest/general_info.html>`_. |
README.md
Outdated
| </p> | ||
|
|
||
| 7. Choose **Express** and select the download server: | ||
| 7. Alternatively, you can download the ESP-IDF Install Manager from the following link [ESP-IDF Install Manager](https://dl.espressif.com/dl/eim/index.html) among the following options:: |
There was a problem hiding this comment.
"Installation Manager" here as well.
README.md
Outdated
| 10. If your operating system is MacOS/Linux, choose the system Python executable to create ESP-IDF virtual environment inside ESP-IDF Tools and install ESP-IDF Python package there. | ||
|
|
||
| > **NOTE:** Windows users don't need to select a Python executable since it is going to be installed by this setup. | ||
| 8. Use the ESP-IDF Install Manager to install the ESP-IDF and tools. If necessary, here is the [ESP-IDF Install Manager Documentation](https://docs.espressif.com/projects/idf-im-ui/en/latest/general_info.html). |
There was a problem hiding this comment.
"Installation Manager"
…idf setup within progress status
|
I've installed the .vsix and came back with some more feedback regarding the walkthroughs. The updates are not really needed but they could be a nice cleanup for 2.0 release.
|
|
Here are some changes required for the documentation: 1) docs_espressif\en\additionalfeatures\app-tracing.rst - New Project reference needs to be updated 2) docs_espressif\en\additionalfeatures\coverage.rst - same here 3) docs_espressif\en\additionalfeatures\flash-encryption.rst - Same here (documentation is mentioning 4) docs_espressif\en\additionalfeatures\heap-tracing.rst - same here 5) Skipping tag 2.0.0 - I've also noticed that in the changelog we use 2.0.2, skipping 2.0.0, I forgot if this was intentional or not. |








Description
EIM Integration Release
This pull request significantly refactors the CI workflow and documentation to modernize ESP-IDF installation, simplify test execution, and update configuration guidance for additional frameworks. The most impactful changes are the removal of the custom Docker-based GitHub Action in favor of using Espressif’s official setup action, improvements to test reporting, and updates to documentation for clarity and current best practices.
CI/CD Pipeline Modernization:
.github/actions/idfDocker-based GitHub Action, including itsDockerfile,action.yml, and shell scripts, in favor of using the officialespressif/install-esp-idf-actionfor setting up ESP-IDF in CI workflows. This simplifies maintenance and aligns with upstream best practices. [1] [2] [3] [4].github/workflows/ci.ymland.github/workflows/ui-test.ymlto use the official ESP-IDF setup action, improved Node.js and Yarn setup, and replaced custom test output handling with standardized test reporting usingdorny/test-reporter. Also added robust JSON extraction and artifact upload for UI test results. [1] [2] [3]Documentation Updates:
README.mdto recommend using the ESP-IDF Install Manager and updated the workflow for selecting and configuring ESP-IDF versions in VS Code. This reflects the latest recommended installation and configuration processes. [1] [2]idf.customExtraVarsinstead of deprecated configuration keys, both in English and Chinese documentation. [1] [2] [3] [4] [5] [6]These changes collectively improve maintainability, reduce custom code, and ensure that both CI and user documentation are up-to-date with current Espressif tooling and extension capabilities.
Fix #1696
Fix #1759
Type of change
Steps to test this pull request
This PR requires an overall test of the extension to make sure all features work. This PR include breaking changes in the way the ESP-IDF is installed now using the ESP-IDF Installation Manager (EIM)
Install using the EIM.
How has this been tested?
Manual testing of overall extension features.
Test Configuration:
Checklist